Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation for url does not seem to allow for hostname only URLs #612

Closed
chrishoage opened this issue Dec 15, 2024 · 3 comments · Fixed by #626
Closed

Form Validation for url does not seem to allow for hostname only URLs #612

chrishoage opened this issue Dec 15, 2024 · 3 comments · Fixed by #626
Labels
bug Something isn't working

Comments

@chrishoage
Copy link
Contributor

Describe the bug
Pointing to my healthchecks instance on my internal docker network using the docker hostname fails.

To Reproduce
Steps to reproduce the behavior:

  1. Go to plan management
  2. Click on hooks
  3. Add healthcekcs with a host name only url
  4. See error

Expected behavior
TLDs are not required for URLs. Ant design system component library seems to feel otherwise

Screenshots

image

image

Platform Info

  • Docker amd64
  • Backrest Version v1.6.2
@chrishoage chrishoage added the bug Something isn't working label Dec 15, 2024
@chrishoage
Copy link
Contributor Author

Wondering if the best course of action is to remove { type: "url" } from the rules?

It does not seem to add much value, in particular since this seems like an upstream bug:

image

@garethgeorge if the above is acceptable to you I can open an PR (next week) with removing the rules in the form for all URL inputs.

@garethgeorge
Copy link
Owner

Reducing the validation to simply a text field absolutely makes sense to me here, agree with that change. If it's something you have bandwidth to PR that sounds great :)

@chrishoage
Copy link
Contributor Author

PR open - as mentioned in the body of the PR I removed all type: "url" rules but please let me know if you'd prefer to leave the ones for slack and discord and I will restore those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants