You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would be nice to make it minification safe though - If one imports ngSlient and then minificates the bundle (e.g. with webpack), the whole app could fail.
Cheers
The text was updated successfully, but these errors were encountered:
@garakh it looks like there is no need for a PR. The root cause of the issue is that the npm package is not minification safe, however, the code in the repo is.
Diff
$ cd /tmp && npm i ngsilent && curl -O https://raw.githubusercontent.com/garakh/ngSilent/master/ngSilent.js && diff node_modules/ngsilent/ngSilent.js ngSilent.js
Workaround: npm i garakh/ngSilent instead of npm i ngsilent
Could you please update the npm package to make sure they are pointing to the same source?
Hi - first of all, thanks for this great package.
Would be nice to make it minification safe though - If one imports ngSlient and then minificates the bundle (e.g. with webpack), the whole app could fail.
Cheers
The text was updated successfully, but these errors were encountered: