Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ngSilent minification safe #10

Open
aberenyi opened this issue Dec 2, 2016 · 3 comments
Open

make ngSilent minification safe #10

aberenyi opened this issue Dec 2, 2016 · 3 comments

Comments

@aberenyi
Copy link

aberenyi commented Dec 2, 2016

Hi - first of all, thanks for this great package.

Would be nice to make it minification safe though - If one imports ngSlient and then minificates the bundle (e.g. with webpack), the whole app could fail.

Cheers

@garakh
Copy link
Owner

garakh commented Dec 3, 2016

You are welcome to implement this feature :)

@aberenyi
Copy link
Author

aberenyi commented Dec 3, 2016

@garakh haha, fair enough - will create a PR next week

@aberenyi
Copy link
Author

aberenyi commented Dec 8, 2016

@garakh it looks like there is no need for a PR. The root cause of the issue is that the npm package is not minification safe, however, the code in the repo is.

Diff

$ cd /tmp && npm i ngsilent && curl -O https://raw.githubusercontent.com/garakh/ngSilent/master/ngSilent.js && diff node_modules/ngsilent/ngSilent.js ngSilent.js

Workaround: npm i garakh/ngSilent instead of npm i ngsilent

Could you please update the npm package to make sure they are pointing to the same source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants