Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-claiming efficient 8bit computations in CosetLeadersMatFFE #104

Open
osj1961 opened this issue Jan 26, 2025 · 0 comments
Open

Re-claiming efficient 8bit computations in CosetLeadersMatFFE #104

osj1961 opened this issue Jan 26, 2025 · 0 comments

Comments

@osj1961
Copy link
Collaborator

osj1961 commented Jan 26, 2025

Inside CosetLeadersMatFFE there is an if-elif-else construct that divies up the actual work based on whether the code is over GF(2), an "ok8" field that can be represented in 8-bits, or a generic GF(q) w/ q>256. In the ok8 case certain cosets were getting missed leading to a returned list with unbound entries. I made a local (to guava) version of the function called GuavaCosetLeadersMatFFE and commented out the ok8 branch (i.e. let even smallish fields be handled by the general case).
This fixes the errors in CoveringRadius and SyndromeTable, but loses some of the speedup previously achieved for codes over the ok8 fields.
So this "fix" must be considered temporary and reverted once a fix can be found for the CosetLeadersMatFFE method in gap/lib/listcoef.gi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant