jupyter integration not working properly on remote jupyter lab

[auderson]

The "VizTracer Report" button will not work if user is using remote jupyter, because the code is running on the server side. However user can still open the page manully from his local browser.

viztracer/src/viztracer/cellmagic.py

Lines 53 to 63 in 9f17472

	def view(): # pragma: no cover
	server = ServerThread(file_path, port=options.port, once=True)
	server.start()
	server.ready.wait()
	import webbrowser
	webbrowser.open_new_tab(f'http://127.0.0.1:{server.port}')
	button = Button(description="VizTracer Report")
	button.on_click(lambda b: view())
	display(button)

[gaogaotiantian]

When a webserver is hosted remotely, you can open a local browser and access it? That sounds a bit off. I don't use jupyter personally so jupyter has never been the first class citizen for viztracer. I don't have any solutions by hand even though I can understand the issue.

[auderson]

Well…By saying remote & local I actually mean the Ubuntu server of my company & my office desktop, they’re in the same network.

I don't use jupyter personally so jupyter has never been the first class citizen for viztracer.

No big deal, the VizViewer CLI is good.

I don't have any solutions by hand even though I can understand the issue.

Yes, this issue is quite easy to understand, but the solution may not be so straightforward.