Solve #804 with simple solution #1042
Closed
Silvigarabis
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Recently I ran into a similar issue to #804 on my Paper server. After an Offline player is linked to a Bedrock player, logging into the server as a Bedrock player will require the offline player to log in with premium later.
I took a look at some of these discussions or other discussion pages it has linked to, and found that this problem is very difficult to solve perfectly, requiring more code to be written.
Since I only needed to get this problem fixed on my server and nothing else, I forked the repository and spent hours poring over the code, and I found the minimum change solution:
In
ForceloginManagement.run()
, do not attempt to correct the premium status of players whoseisOnlineMode()
returnstrue
(see this commit).It works very well, and with a specific configuration (see https://hastebin.com/share/pacitetejo.yaml), the #804 issue above is well resolved, making linked Offline Java Edition players can still log in with a password through the login plugin.
But I'm still curious what impact this modification might have, and even cause bugs in some scenarios?
Beta Was this translation helpful? Give feedback.
All reactions