Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreal2: Players with an ID of 0 are still added to player list #147

Open
Douile opened this issue Oct 30, 2023 · 0 comments
Open

Unreal2: Players with an ID of 0 are still added to player list #147

Douile opened this issue Oct 30, 2023 · 0 comments
Labels
bug Something isn't working protocol This is something regarding a protocol v0.5.X Things about v0.5.X
Milestone
Backlog

Comments

@Douile
Copy link
Collaborator

Douile commented Oct 30, 2023

Describe the bug
In the current unreal2 implementation we check whether the ping is 0 but not the ID. In the node implementation players with an ID of 0 are not included in the player output.

Expected behavior
I'm not sure but most likely we should follow the node implementation as there is no documentation on the protocol that I could find.

Additional context
Node implementation
@Douile Douile added bug Something isn't working protocol This is something regarding a protocol labels Oct 30, 2023
@cainthebest cainthebest added this to the Backlog milestone Sep 30, 2024
@cainthebest cainthebest added the v0.5.X Things about v0.5.X label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working protocol This is something regarding a protocol v0.5.X Things about v0.5.X
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Douile @cainthebest