Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to loosen the dependency on stable-baselines3 #8

Open
Agnes-U opened this issue Nov 9, 2022 · 0 comments
Open

Suggest to loosen the dependency on stable-baselines3 #8

Agnes-U opened this issue Nov 9, 2022 · 0 comments

Comments

@Agnes-U
Copy link

Agnes-U commented Nov 9, 2022

Hi, your project roguelife(commit id: eb06dcb) requires "stable-baselines3==1.1.0" in its dependency. After analyzing the source code, we found that the following versions of stable-baselines3 can also be suitable, i.e., stable-baselines3 1.1.0a11, since all functions that you directly (7 APIs: stable_baselines3.dqn.dqn.DQN.predict, stable_baselines3.common.vec_env.dummy_vec_env.DummyVecEnv.reset, stable_baselines3.common.vec_env.dummy_vec_env.DummyVecEnv.init, stable_baselines3.dqn.dqn.DQN.init, stable_baselines3.common.vec_env.base_vec_env.VecEnv.step, stable_baselines3.common.base_class.BaseAlgorithm.load, stable_baselines3.dqn.dqn.DQN.learn) or indirectly (propagate to -7 stable-baselines3's internal APIs and 142 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on stable-baselines3 from "stable-baselines3==1.1.0" to "stable-baselines3>=1.1.0a11,<=1.1.0". This will improve the applicability of roguelife and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on stable-baselines3?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant