Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuPath ROIsplitter to 0.2.1 #757

Closed
wants to merge 10 commits into from

Conversation

npinter
Copy link
Contributor

@npinter npinter commented Apr 22, 2024

Includes a fix for filling ROIs of manually annotated data.

@bgruening
Copy link
Member

Exception: Test output defines nothing to check (e.g. must have a 'file' check against, assertions to check, metadata or checksum tests, etc...)

Add some asserts, if you like. We do have new stuff in 24.0 https://docs.galaxyproject.org/en/latest/dev/schema.html#assertions-for-image-data

@npinter
Copy link
Contributor Author

npinter commented Apr 23, 2024

Exception: Test output defines nothing to check (e.g. must have a 'file' check against, assertions to check, metadata or checksum tests, etc...)

Add some asserts, if you like. We do have new stuff in 24.0 https://docs.galaxyproject.org/en/latest/dev/schema.html#assertions-for-image-data

mmh looks like it doesn't work for output collection elements

.. ERROR: Test 1: unknown assertion 'has_image_width'
.. ERROR: Test 1: unknown assertion 'has_image_width'

@bgruening
Copy link
Member

I think it will work when we update the testing to use 24.0. Working on it.

@bgruening
Copy link
Member

Please rebase: 8e3a5e1

The new image tests will work now.

@npinter npinter closed this Apr 23, 2024
@npinter npinter deleted the update-roisplitter branch April 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants