Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropzone in upload modal does not trigger #18994

Open
martenson opened this issue Oct 15, 2024 · 8 comments
Open

dropzone in upload modal does not trigger #18994

martenson opened this issue Oct 15, 2024 · 8 comments

Comments

@martenson
Copy link
Member

Without modal the whole UI is a dropzone. Once you open a modal nothing is a dropzone despite hint saying otherwise.

Screenshot 2024-10-15 at 9 19 35 AM

Galaxy Version and/or server at which you observed the bug
Main b56ad8d12a77da51dc9129e4c80705dd46c19839

Browser and Operating System
chrome macos

@ahmedhamidawan
Copy link
Member

I am not able to reproduce this anymore, does anyone remember a way to trigger this? The default behavior works correctly right now on 24.2

@mvdbeek
Copy link
Member

mvdbeek commented Dec 10, 2024

It does not work, you need to be on the welcome page. It may or may not depend on the specific welcome page, so try WEBPACK_PORT=8082 CHANGE_ORIGIN=true GALAXY_URL="https://usegalaxy.org/" yarn run develop

@ahmedhamidawan
Copy link
Member

Testing this out on dev server with origin pointing to usegalaxy.org, and I can't reproduce this:
firefox_DZQ5pckdI8

Maybe there was some other way to reproduce this?

@mvdbeek
Copy link
Member

mvdbeek commented Dec 11, 2024

You don't seem to be using the upload modal before dragging ?

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Dec 11, 2024

What do you mean by using it before dragging? As in having data in there beforehand?

It still works fine with that:
firefox_Xl7ntABMHY

@mvdbeek
Copy link
Member

mvdbeek commented Dec 11, 2024

Yeah, that doesn't work for me, OSX, chrome

@ahmedhamidawan
Copy link
Member

I've tried chrome and firefox both on Windows. I can also try to reproduce this on my macbook, see if its reproducible there for me

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Dec 14, 2024

Oh wow, yes, it is reproducible on mac on Chrome! On Windows it was fine and Firefox on mac also works. Update, it is broken everywhere. The way to reproduce was to place an Explorer or Finder window over the central iframe, and try to drag and drop there onto the iframe Will try to debug this...

There is a certain part of the drop area (not over the iframe) that works but the rest (over the iframe) doesn't.

Screen.Recording.2024-12-14.at.10.58.01.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants