Fix goconvey service for newer Go versions.

This is a bit of a temporary patch; I think the time has come to
completely rebuild `goconvey` to rely on `go test -json` as the next
thing to do.

Author: riannucci

web/server/parser/packageParser.go

@@ -138,11 +138,15 @@ func (self *outputParser) recordTestingOutcome(outcome string) {
 	self.result.PackageName = strings.TrimSpace(fields[1])
 	self.result.Elapsed = parseDurationInSeconds(fields[2], 3)
 }
+
+var coverageStatementRE = regexp.MustCompile(`coverage: (\d+\.\d)% of statements`)
+
 func (self *outputParser) recordCoverageSummary(summary string) {
-	start := len("coverage: ")
-	end := strings.Index(summary, "%")
-	value := summary[start:end]
-	parsed, err := strconv.ParseFloat(value, 64)
+	matches := coverageStatementRE.FindStringSubmatch(summary)
+	if len(matches) == 0 {
+		panic("recordCoverageSummary")
+	}
+	parsed, err := strconv.ParseFloat(matches[1], 64)
 	if err != nil {
 		self.result.Coverage = -1
 	} else {

web/server/parser/rules.go

@@ -41,5 +41,5 @@ func packagePassed(line string) bool {
 	return strings.HasPrefix(line, "ok  \t")
 }
 func isCoverageSummary(line string) bool {
-	return strings.HasPrefix(line, "coverage: ") && strings.Contains(line, "% of statements")
+	return strings.Contains(line, "coverage: ") && strings.Contains(line, "% of statements")
 }

web/server/system/shell.go

@@ -158,4 +158,4 @@ func (this Command) Execute() Command {
 const goconveyDSLImport = "github.com/smartystreets/goconvey/convey " // note the trailing space: we don't want to target packages nested in the /convey package.
 const gopathProblem = "Please run goconvey from within $GOPATH/src (also, symlinks might be problematic). Output and Error: "
 
-var coverageStatementRE = regexp.MustCompile(`(?m)^coverage: \d+\.\d% of statements(.*)$|^panic: test timed out after `)
+var coverageStatementRE = regexp.MustCompile(`(?m)coverage: \d+\.\d% of statements(.*)$|^panic: test timed out after `)