Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/shadcn fileinput upload #777

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/shadcn fileinput upload #777

wants to merge 2 commits into from

Conversation

jadewale
Copy link
Collaborator

@jadewale jadewale commented Feb 10, 2025 •
edited
Loading

Screenshot 2025-02-10 at 14 42 41 Screenshot 2025-02-10 at 14 42 30

@jadewale jadewale marked this pull request as ready for review February 10, 2025 21:17
MillanWangGadget
MillanWangGadget reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@MillanWangGadget MillanWangGadget left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🍏 Adding a file to the input makes the correct API call and has equivalent with Polaris
  • 🍏 Retrieving existing records containing files works as well
  • 🍏 File size validation works well
  • 🟡 Could you add a generic file icon when a non image file is added?
    • You can test this easily by adding an early return; to useFileInputController->onlyImagesValidation
    • CleanShot 2025-02-10 at 16 46 29@2x

packages/react/src/auto/shadcn/inputs/ShadcnAutoFileInput.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In here it seems like fileUploadContainer has the same logic as the polaris counterpart, but with different rendered components. Do you see any way that these could be refactored such that only the rendering occurs here and the shared logic gets moved to useFileInputController?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillanWangGadget MillanWangGadget MillanWangGadget left review comments

@airhorns airhorns Awaiting requested review from airhorns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadewale @MillanWangGadget