diff --git a/CHANGELOG.md b/CHANGELOG.md index ff0fa5b6..4f9f079f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # CHANGELOG +## 0.2.19 (March 14th, 2017) + +- Removed rubber band effect from list view + ## 0.2.18 (March 14th, 2017) - Fixed an issue with OS detection diff --git a/docs/mac-os/list-view.md b/docs/mac-os/list-view.md index 8da3c4e2..474d74fe 100644 --- a/docs/mac-os/list-view.md +++ b/docs/mac-os/list-view.md @@ -7,7 +7,6 @@ Property | Type | Description :------------------ | :-------------:| :---------- background | string | Sets the background color of a component. -disableRubberBand | bool | Disables the rubber band effect on the list view. height | number | Sets the height of a component. hidden | bool | Sets the visibility of a component. margin | string, number | Sets the outer margin of a component.
__E.G.__ _"30px 20px"_ diff --git a/package.json b/package.json index b8e3794e..b7b2cbf2 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "react-desktop", "author": "Gabriel Bull", - "version": "0.2.18", + "version": "0.2.19", "description": "React UI Components for macOS Sierra and Windows 10", "main": "./index.js", "keywords": [ @@ -34,8 +34,7 @@ "build-publish": "npm run build && npm publish ./build" }, "dependencies": { - "radium": "^0.18.1", - "rubber-band-effect": "^0.1.1" + "radium": "^0.18.1" }, "peerDependencies": { "react": "^15.0.0", diff --git a/src/listView/macOs/listView.js b/src/listView/macOs/listView.js index c312d556..ef92cd97 100644 --- a/src/listView/macOs/listView.js +++ b/src/listView/macOs/listView.js @@ -9,7 +9,6 @@ import Padding, { paddingPropTypes } from '../../style/padding'; import Header from './header/header'; import Footer from './footer/footer'; import Row from './row/row'; -import rubberBandEffect from 'rubber-band-effect'; @Background() @Dimension() @@ -22,20 +21,9 @@ class ListView extends Component { ...dimensionPropTypes, ...hiddenPropTypes, ...marginPropTypes, - ...paddingPropTypes, - disableRubberBand: PropTypes.bool + ...paddingPropTypes }; - static defaultProps = { - disableRubberBand: false - }; - - componentDidMount() { - if (!this.props.disableRubberBand) { - rubberBandEffect(ReactDOM.findDOMNode(this.refs.scrollable)); - } - } - mapChildren(children) { let hasDirectRows = false; let header = null, items = null, footer = null; @@ -57,7 +45,6 @@ class ListView extends Component { render() { const { children, style, ...props } = this.props; - delete props.disableRubberBand; const { header, items, footer } = this.mapChildren(children);