Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: position of child matches #46

Open
IlliaHreben opened this issue Dec 2, 2022 · 2 comments
Open

Fix: position of child matches #46

IlliaHreben opened this issue Dec 2, 2022 · 2 comments

Comments

@IlliaHreben
Copy link

Hey, thank you for your work!
I want to improve it a bit. The point is when the parent element has only one child (like on the screenshot) column doesn't care about it and shifts it to the top. So I place the empty value on the index when the match shouldn't be. It's just my implementation, it works, but you can change it however you want. I just wanted to present the issue and idea of how to solve it.

#45

image

@IlliaHreben IlliaHreben changed the title Fix position of child matches https://github.com/g-loot/react-tournament-brackets/pull/45 Fix position of child matches Dec 2, 2022
@IlliaHreben IlliaHreben changed the title Fix position of child matches Fix: position of child matches Dec 2, 2022
@Shenato
Copy link
Contributor

Shenato commented Dec 20, 2022

Hey thank you so much for bringing up this issue and providing a PR solving it, could you provide an example snippet of how you managed to get this state so i can recreate this locally? My thinking is if this is a bug we should probably add a test case against it so i can review your PR more properly 👍

I'm in the process of making test cases so the library can be further improved more easily by the community.

@Diday
Copy link

Diday commented Feb 11, 2024

I do agree with this idea, sample in my case to optimize the matches (without a bye position) like in challonge.com
Screen Shot 2024-01-25 at 14 46 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants