You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thank you for your work!
I want to improve it a bit. The point is when the parent element has only one child (like on the screenshot) column doesn't care about it and shifts it to the top. So I place the empty value on the index when the match shouldn't be. It's just my implementation, it works, but you can change it however you want. I just wanted to present the issue and idea of how to solve it.
The text was updated successfully, but these errors were encountered:
IlliaHreben
changed the title
Fix position of child matches https://github.com/g-loot/react-tournament-brackets/pull/45
Fix position of child matches
Dec 2, 2022
IlliaHreben
changed the title
Fix position of child matches
Fix: position of child matches
Dec 2, 2022
Hey thank you so much for bringing up this issue and providing a PR solving it, could you provide an example snippet of how you managed to get this state so i can recreate this locally? My thinking is if this is a bug we should probably add a test case against it so i can review your PR more properly 👍
I'm in the process of making test cases so the library can be further improved more easily by the community.
Hey, thank you for your work!
I want to improve it a bit. The point is when the parent element has only one child (like on the screenshot) column doesn't care about it and shifts it to the top. So I place the empty value on the index when the match shouldn't be. It's just my implementation, it works, but you can change it however you want. I just wanted to present the issue and idea of how to solve it.
#45
The text was updated successfully, but these errors were encountered: