Merge branch 'release/v2.4.x'

Author: andydotxyz

CHANGELOG.md

@@ -3,6 +3,27 @@
 This file lists the main changes with each version of the Fyne toolkit.
 More detailed release notes can be found on the [releases page](https://github.com/fyne-io/fyne/releases). 
 
+## 2.4.4 - 13 February 2024
+
+### Fixed
+
+* Spaces could be appended to linux Exec command during packaging
+* Secondary mobile windows would not size correctly when padded
+* Setting Icon.Resource to nil will not clear rendering
+* Dismiss iOS keyboard if "Done" is tapped
+* Large speed improvement in Entry and GridWrap widgets
+* tests fail with macOS Assertion failure in NSMenu (#4572)
+* Fix image test failures on Apple Silicon
+* High CPU use when showing CustomDialogs (#4574)
+* Entry does not show the last (few) changes when updating a binding.String in a fast succession (#4082)
+* Calling Entry.SetText and then Entry.Bind immediately will ignore the bound value (#4235)
+* Changing theme while application is running doesn't change some parameters on some widgets (#4344)
+* Check widget: hovering/tapping to the right of the label area should not activate widget (#4527)
+* Calling entry.SetPlaceHolder inside of OnChanged callback freezes app (#4516)
+* Hyperlink enhancement: underline and tappable area shouldn't be wider than the text label (#3528)
+* Fix possible compile error from go-text/typesetting
+
+
 ## 2.4.3 - 23 December 2023
 
 ### Fixed

cmd/fyne/internal/templates/bundled.go

@@ -3,7 +3,7 @@ Type=Application
 Name={{.Name}}
 {{- if ne .GenericName ""}}
 GenericName={{.GenericName}}{{end}}
-Exec={{.Exec}} {{.ExecParams}}
+Exec={{.Exec}} {{- .ExecParams}}
 Icon={{.Name}}
 {{- if ne .Comment ""}}
 Comment={{.Comment}}{{end}}

cmd/fyne/internal/templates/data/app.desktop

@@ -129,12 +129,12 @@ func (c *Container) Refresh() {
 // This method is not intended to be used inside a loop, to remove all the elements.
 // It is much more efficient to call RemoveAll() instead.
 func (c *Container) Remove(rem CanvasObject) {
+	c.lock.Lock()
+	defer c.lock.Unlock()
 	if len(c.Objects) == 0 {
 		return
 	}
 
-	c.lock.Lock()
-	defer c.lock.Unlock()
 	for i, o := range c.Objects {
 		if o != rem {
 			continue

container.go

@@ -57,6 +57,7 @@ func (t *AppTabs) CreateRenderer() fyne.WidgetRenderer {
 		appTabs: t,
 	}
 	r.action = r.buildOverflowTabsButton()
+	r.tabs = t
 
 	// Initially setup the tab bar to only show one tab, all others will be in overflow.
 	// When the widget is laid out, and we know the size, the tab bar will be updated to show as many as can fit.

container/apptabs.go

@@ -67,6 +67,8 @@ func (t *DocTabs) CreateRenderer() fyne.WidgetRenderer {
 	}
 	r.action = r.buildAllTabsButton()
 	r.create = r.buildCreateTabsButton()
+	r.tabs = t
+
 	r.box = NewHBox(r.create, r.action)
 	r.scroller.OnScrolled = func(offset fyne.Position) {
 		r.updateIndicator(false)

container/doctabs.go

@@ -292,6 +292,8 @@ type baseTabsRenderer struct {
 	action             *widget.Button
 	bar                *fyne.Container
 	divider, indicator *canvas.Rectangle
+
+	tabs baseTabs
 }
 
 func (r *baseTabsRenderer) Destroy() {
@@ -304,6 +306,10 @@ func (r *baseTabsRenderer) applyTheme(t baseTabs) {
 	r.divider.FillColor = theme.ShadowColor()
 	r.indicator.FillColor = theme.PrimaryColor()
 	r.indicator.CornerRadius = theme.SelectionRadiusSize()
+
+	for _, tab := range r.tabs.items() {
+		tab.Content.Refresh()
+	}
 }
 
 func (r *baseTabsRenderer) layout(t baseTabs, size fyne.Size) {

container/tabs.go

@@ -3,10 +3,14 @@ package container
 import (
 	"testing"
 
+	"github.com/stretchr/testify/assert"
+
+	"fyne.io/fyne/v2"
 	"fyne.io/fyne/v2/canvas"
 	"fyne.io/fyne/v2/internal/cache"
+	"fyne.io/fyne/v2/test"
 	"fyne.io/fyne/v2/theme"
-	"github.com/stretchr/testify/assert"
+	"fyne.io/fyne/v2/widget"
 )
 
 func TestTabButton_Icon_Change(t *testing.T) {
@@ -19,3 +23,26 @@ func TestTabButton_Icon_Change(t *testing.T) {
 	b.Refresh()
 	assert.NotEqual(t, oldResource, icon.Resource)
 }
+
+func TestTab_ThemeChange(t *testing.T) {
+	a := test.NewApp()
+	defer test.NewApp()
+	a.Settings().SetTheme(theme.LightTheme())
+
+	tabs := NewAppTabs(
+		NewTabItem("a", widget.NewLabel("a")),
+		NewTabItem("b", widget.NewLabel("b")))
+	w := test.NewWindow(tabs)
+	w.Resize(fyne.NewSize(180, 120))
+
+	initial := w.Canvas().Capture()
+
+	a.Settings().SetTheme(theme.DarkTheme())
+	tabs.SelectIndex(1)
+	second := w.Canvas().Capture()
+	assert.NotEqual(t, initial, second)
+
+	a.Settings().SetTheme(theme.LightTheme())
+	tabs.SelectIndex(0)
+	assert.Equal(t, initial, w.Canvas().Capture())
+}

container/tabs_test.go

@@ -8,6 +8,7 @@ import (
 	"fyne.io/fyne/v2/canvas"
 	"fyne.io/fyne/v2/container"
 	col "fyne.io/fyne/v2/internal/color"
+	"fyne.io/fyne/v2/layout"
 	"fyne.io/fyne/v2/theme"
 	"fyne.io/fyne/v2/widget"
 )
@@ -108,8 +109,15 @@ func (d *dialog) hideWithResponse(resp bool) {
 func (d *dialog) create(buttons fyne.CanvasObject) {
 	label := widget.NewLabelWithStyle(d.title, fyne.TextAlignLeading, fyne.TextStyle{Bold: true})
 
+	var image fyne.CanvasObject
+	if d.icon != nil {
+		image = &canvas.Image{Resource: d.icon}
+	} else {
+		image = &layout.Spacer{}
+	}
+
 	content := container.New(&dialogLayout{d: d},
-		&canvas.Image{Resource: d.icon},
+		image,
 		newThemedBackground(),
 		d.content,
 		buttons,

dialog/base.go

@@ -689,7 +689,7 @@ func (f *FileDialog) SetDismissText(label string) {
 	f.dialog.win.Refresh()
 }
 
-// SetLocation tells this FileDirectory which location to display.
+// SetLocation tells this FileDialog which location to display.
 // This is normally called before the dialog is shown.
 //
 // Since: 1.4