-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In AdwaitaTheme(), dark mode is only when the system setting is dark #86
Comments
How does the code |
Ok, sure. But I see this in the code:
I'm just not sure how to invoke 'dark' or 'light' in this scheme with APIs. |
Most themes don't offer any variant setting, and the adwaita is the same. But you can create a new theme that wraps this one and specify the |
I have just realised this code doesn't mention Adwaita at all - maybe it was a bad paste? |
Sorry, you are right. I used to do this:
this works fine. until I changed system mode to 'light' |
You are pasting custom code but not explaining how it works. |
maybe i misunderstood the AdwaitaTheme, i thought it could be integrated into the fyne theme. |
All fyne themes reflect the OS user preference for light/dark, is this not what you are seeing? To force one variant you could wrap the theme and force your |
what i'm seeing is this, it i do: it works, regardless of the host system mode setting but if i'm changing to: what i'm seeing is that, if the host system is in dark mode, it works fine. |
These are deprecated because it ignores the user preference which is not what we want to see happen.
Isn't that correct? the theme is matching the user setting. When you call |
but I would think more specific should always overwrite the less specific. If my app has a button to turn it to 'dark' mode, then regardless of the global setting, it should be dark. This is more specific user preference. |
Ok, and how have you coded it so that preference overrides the system default? |
This code seems to work only if the system setting is in 'dark' mode.
The text was updated successfully, but these errors were encountered: