Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty clientSecret #56

Open
dborysenko opened this issue Jun 28, 2022 · 3 comments
Open

Allow empty clientSecret #56

dborysenko opened this issue Jun 28, 2022 · 3 comments
Assignees

Comments

@dborysenko
Copy link

Is your feature request related to a problem? Please describe.
It is a valid use case where OIDC Provider does not require client secret for a client. It would make sense to allow loginapp to accept no client secret.

Describe the solution you'd like
Make clientSecret field optional.

Describe alternatives you've considered

Additional context

@fydrah
Copy link
Owner

fydrah commented Jun 28, 2022

Hi @dborysenko !

Ok, I didn't know this was possible, by any chance do you have an example or a documentation I could refer to for testing purpose?

@dborysenko
Copy link
Author

Hey @fydrah,
Thanks for quick response.
My use case is AWS EKS clusters using OIDC provider for authentication/authorization. EKS do not require clientSecret, moreover it does not even support clientSecret. Please refer to AWS doc: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-identityproviderconfig-oidcidentityproviderconfig.html

@adrahun
Copy link

adrahun commented Jul 14, 2023

Hi, still would be nice to have such an option! (example - Dex supports public clients).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants