Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the MLPs same as in the paper? #86

Open
kuzand opened this issue Aug 8, 2021 · 1 comment
Open

Are the MLPs same as in the paper? #86

kuzand opened this issue Aug 8, 2021 · 1 comment

Comments

@kuzand
Copy link

kuzand commented Aug 8, 2021

In the paper, the first MLP (64, 64) has two layers and the second MLP (64,128,1024) has three layers.
In the implementation of PointNetfeat here, the first MLP has just one layer of size 64 and the second MLP has two layers of sizes 128 and 1024 as can be seen from the code below:

self.conv1 = torch.nn.Conv1d(3, 64, 1)
self.conv2 = torch.nn.Conv1d(64, 128, 1)
self.conv3 = torch.nn.Conv1d(128, 1024, 1)

It works fine, but to be consistent with the paper the following modifications can be made:

# First MLP
self.conv1 = torch.nn.Conv1d(3, 64, 1)
self.conv2 = torch.nn.Conv1d(64, 64, 1)

# Second MLP
self.conv3 = torch.nn.Conv1d(64, 64, 1)
self.conv4 = torch.nn.Conv1d(64, 128, 1)
self.conv5 = torch.nn.Conv1d(128, 1024, 1)

and then modify the forward method accordingly.

@kuzand kuzand changed the title Are the MLPs same as in paper? Are the MLPs same as in the paper? Aug 8, 2021
@chenxl124578
Copy link

I also find this difference, and i noted that there is another issue which have the same question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants