Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/related articles query issue #35

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

louisholley
Copy link
Contributor

fixes #30

the strategy is to shuffle the tags (so we get different related articles each time) before reducing them into a search query with a max length of 512 characters

@louisholley louisholley changed the base branch from main to dev January 31, 2023 13:27
article.title // start the query with the title
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above here is the fix, the rest of the changes are prettier formatting

@GemN
Copy link
Contributor

GemN commented Jan 31, 2023

shit, I should have assigned myself on it. I wanted to fix this problem in the branch fix/search using algolia recommend but I'm still waiting on dev access.

The problem with the current search implementation is that default algolia do some kind of join on tag (instead of using facets feature, could be another fix) and so most of the time return nothing for recommandations

@louisholley louisholley marked this pull request as draft January 31, 2023 16:19
@louisholley louisholley removed the request for review from maerzhase January 31, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Article] Related articles throw errors when main article has too much tags
2 participants