Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "address-of" operator & in arm_reg_ptr function. #38

Open
enlighten5 opened this issue Nov 27, 2023 · 2 comments
Open

Missing "address-of" operator & in arm_reg_ptr function. #38

enlighten5 opened this issue Nov 27, 2023 · 2 comments

Comments

@enlighten5
Copy link

It looks to me that the arm_reg_ptr function is getting the reference of arm registers, but the reference operator & is missing when handling registers from R0 to R12 and D0 to D31, as shown in this fix.

Please let me know if this makes sense.

Regards.

@Scepticz
Copy link
Contributor

Hi enlighten5,

that makes sense. I think this was due to the fact that the API is used for the NVIC implementation which does not use the general purpose registers. If you like, you could create a pull request.

Tobi

@enlighten5
Copy link
Author

Sure, I've created a pull request.

Also, I am wondering if you plan to upgrade the unicorn emulator to the latest version.

I tried to port your changes to Unicorn to the latest version. but there are some crashes when running with the pipeline. I haven't looked into it yet but I guess it might be related to incompatibilities with the code in fuzzware_harness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants