Skip to content

Commit beefda2

Browse files
authored
chore: update frontmatter and workflow (#128)
* update frontmatter * fix workflow
1 parent cc55171 commit beefda2

File tree

11 files changed

+51
-255
lines changed

11 files changed

+51
-255
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

.github/auto_assign.yml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.github/workflows/ci-ssg.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@ name: "SSR"
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'src/**'
8-
- 'test/**'
9-
106
pull_request:
117
types: [ opened, reopened, synchronize, ready_for_review ]
128
branches: [ main ]
13-
paths:
14-
- 'src/**'
15-
- 'test/**'
169

1710
jobs:
1811
ci:
@@ -23,6 +16,7 @@ jobs:
2316
working-directory: test/ssr
2417
steps:
2518
- uses: actions/checkout@v2
19+
2620
- uses: actions/setup-node@v1
2721
with:
2822
node-version: '14'

.github/workflows/ci-ssr.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,9 @@ name: "SSG"
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'src/**'
8-
- 'test/**'
9-
106
pull_request:
117
types: [ opened, reopened, synchronize, ready_for_review ]
128
branches: [ main ]
13-
paths:
14-
- 'src/**'
15-
- 'test/**'
169

1710
jobs:
1811
ci:
@@ -23,6 +16,7 @@ jobs:
2316
working-directory: test/ssg
2417
steps:
2518
- uses: actions/checkout@v2
19+
2620
- uses: actions/setup-node@v1
2721
with:
2822
node-version: '14'

.github/workflows/ci.yml

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,9 @@ name: CI
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'src/**'
8-
- 'dev/**'
9-
- 'build/**'
10-
- '*.json'
11-
- '*.js'
12-
- '*.ts'
13-
146
pull_request:
157
types: [ opened, reopened, synchronize, ready_for_review ]
168
branches: [ main ]
17-
paths:
18-
- 'src/**'
19-
- 'dev/**'
20-
- 'build/**'
21-
- '*.json'
22-
- '*.js'
23-
- '*.ts'
249

2510
jobs:
2611
build:
@@ -33,23 +18,9 @@ jobs:
3318
with:
3419
node-version: '14'
3520

36-
- uses: actions/cache@v2
37-
with:
38-
path: ~/.npm
39-
key: npm-${{ hashFiles('**/package-lock.json') }}
40-
restore-keys: |
41-
npm-
42-
4321
- run: npm ci
44-
4522
- run: npm run build
4623

47-
- uses: andresz1/size-limit-action@v1
48-
if: github.event_name == 'pull_request'
49-
with:
50-
github_token: ${{ secrets.GITHUB_TOKEN }}
51-
skip_step: install
52-
5324
lint:
5425
name: Lint
5526
runs-on: ubuntu-latest
@@ -60,13 +31,5 @@ jobs:
6031
with:
6132
node-version: '14'
6233

63-
- uses: actions/cache@v2
64-
with:
65-
path: ~/.npm
66-
key: npm-${{ hashFiles('**/package-lock.json') }}
67-
restore-keys: |
68-
npm-
69-
7034
- run: npm ci
71-
7235
- run: npm run lint

.github/workflows/e2e-chrome.yml

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,9 @@ name: chrome
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'cypress/**'
8-
- 'src/**'
9-
- 'dev/**'
10-
116
pull_request:
127
types: [ opened, reopened, synchronize, ready_for_review ]
138
branches: [ main ]
14-
paths:
15-
- 'cypress/**'
16-
- 'src/**'
17-
- 'dev/**'
189

1910
jobs:
2011
main:
@@ -24,20 +15,16 @@ jobs:
2415
steps:
2516
- uses: actions/checkout@v2
2617

18+
- uses: actions/setup-node@v1
19+
with:
20+
node-version: '14'
21+
2722
- name: Cypress run
2823
uses: cypress-io/github-action@v2
2924
with:
30-
record: true
3125
build: npm ci
3226
start: npm run serve
3327
browser: chrome
3428
spec: cypress/integration/functional/*
3529
env:
36-
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
3730
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
38-
39-
- uses: actions/upload-artifact@v1
40-
if: failure()
41-
with:
42-
name: cypress-screenshots
43-
path: cypress/screenshots

.github/workflows/e2e-edge.yml

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,9 @@ name: edge
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'cypress/**'
8-
- 'src/**'
9-
- 'dev/**'
10-
116
pull_request:
127
types: [ opened, reopened, synchronize, ready_for_review ]
138
branches: [ main ]
14-
paths:
15-
- 'cypress/**'
16-
- 'src/**'
17-
- 'dev/**'
189

1910
jobs:
2011
main:
@@ -24,20 +15,16 @@ jobs:
2415
steps:
2516
- uses: actions/checkout@v2
2617

18+
- uses: actions/setup-node@v1
19+
with:
20+
node-version: '14'
21+
2722
- name: Cypress run
2823
uses: cypress-io/github-action@v2
2924
with:
30-
record: true
3125
build: npm ci
3226
start: npm run serve
3327
browser: edge
3428
spec: cypress/integration/functional/*
3529
env:
36-
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
3730
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
38-
39-
- uses: actions/upload-artifact@v1
40-
if: failure()
41-
with:
42-
name: cypress-screenshots
43-
path: cypress/screenshots

.github/workflows/e2e-firefox.yml

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,9 @@ name: firefox
33
on:
44
push:
55
branches: [ main ]
6-
paths:
7-
- 'cypress/**'
8-
- 'src/**'
9-
- 'dev/**'
10-
116
pull_request:
127
types: [ opened, reopened, synchronize, ready_for_review ]
138
branches: [ main ]
14-
paths:
15-
- 'cypress/**'
16-
- 'src/**'
17-
- 'dev/**'
189

1910
jobs:
2011
main:
@@ -27,20 +18,16 @@ jobs:
2718
steps:
2819
- uses: actions/checkout@v2
2920

21+
- uses: actions/setup-node@v1
22+
with:
23+
node-version: '14'
24+
3025
- name: Cypress run
3126
uses: cypress-io/github-action@v2
3227
with:
33-
record: true
3428
build: npm ci
3529
start: npm run serve
3630
browser: firefox
3731
spec: cypress/integration/functional/*
3832
env:
39-
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
4033
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
41-
42-
- uses: actions/upload-artifact@v1
43-
if: failure()
44-
with:
45-
name: cypress-screenshots
46-
path: cypress/screenshots

.github/workflows/triage.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,3 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: fuxingloh/multi-labeler@v1
14-
- uses: kentaro-m/[email protected]

README.md

Lines changed: 26 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,19 @@
1-
[![chrome](https://github.com/fuxingloh/vue-horizontal/workflows/chrome/badge.svg)](https://github.com/fuxingloh/vue-horizontal/actions?query=workflow%3Achrome+branch%3Amain)
2-
[![firefox](https://github.com/fuxingloh/vue-horizontal/workflows/firefox/badge.svg)](https://github.com/fuxingloh/vue-horizontal/actions?query=workflow%3Afirefox+branch%3Amain)
3-
[![edge](https://github.com/fuxingloh/vue-horizontal/workflows/edge/badge.svg)](https://github.com/fuxingloh/vue-horizontal/actions?query=workflow%3Aedge+branch%3Amain)
4-
[![SSR](https://github.com/fuxingloh/vue-horizontal/workflows/SSR/badge.svg)](https://github.com/fuxingloh/vue-horizontal/actions?query=workflow%3ASSR+branch%3Amain)
5-
[![SSG](https://github.com/fuxingloh/vue-horizontal/workflows/SSG/badge.svg)](https://github.com/fuxingloh/vue-horizontal/actions?query=workflow%3ASSG+branch%3Amain)
6-
[![License MIT](https://img.shields.io/github/license/fuxingloh/vue-horizontal)](https://github.com/fuxingloh/vue-horizontal/blob/main/LICENSE)
7-
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Ffuxingloh%2Fvue-horizontal.svg?type=shield)](https://app.fossa.com/projects/git%2Bgithub.com%2Ffuxingloh%2Fvue-horizontal?ref=badge_shield)
8-
91
# [Vue Horizontal](https://vue-horizontal.fuxing.dev) [![vue-horizontal](https://img.shields.io/npm/v/vue-horizontal/latest)](https://www.npmjs.com/package/vue-horizontal) [![vue-horizontal](https://img.shields.io/npm/v/vue-horizontal/next)](https://www.npmjs.com/package/vue-horizontal)
102

11-
Designing your web app for a horizontal experience can tedious and overwhelming if you are new to web development. While
12-
a vertical design comes naturally as html is naturally vertical by design `display:block`. With `display:flex`, aligning
13-
your content horizontally becomes natural and intuitive but it doesn't support overflow or navigation. You start to add
14-
more hacks and tricks to get the design you wanted, but those hacks are not consistent and cross-browser tested, SSG or
15-
SEO friendly. You get the idea.
16-
17-
There are many libraries already in open-source world, some using direct DOM manipulation, some importing another legacy
18-
JavaScript or JQuery library. You don't want that. Vue already does that. This is Vue native created for Vue, and only
19-
Vue is the peer dependency required. All modes of rendering (SPA/SSR/SSG) are supported and tested with E2E tools.
3+
Designing your web app for a horizontal experience can be tedious and overwhelming if you are new to web development.
4+
While a vertical design comes naturally as html is naturally vertical by design `display:block`.
5+
With `display:flex`, aligning your content horizontally becomes natural and intuitive,
6+
but it doesn't support overflow or navigation.
7+
You start to add more hacks and tricks to get the design you wanted, but those hacks are not consistent and
8+
cross-browser tested, SSG or SEO friendly.
9+
You get the idea.
10+
11+
There are many libraries already in an open-source world, some using direct DOM manipulation, some importing another
12+
legacy JavaScript or JQuery library.
13+
You don't want that.
14+
Vue already does that.
15+
This is Vue native created for Vue, and only Vue is the peer dependency required.
16+
All modes of rendering (SPA/SSR/SSG) are supported and tested with E2E tools.
2017

2118
The actual library is only about 400 LOC while there are at least 100x more LOC in the documentation, end-to-end testing
2219
and a bunch of other fun stuff.
@@ -31,9 +28,10 @@ and a bunch of other fun stuff.
3128
- **SSR/SSG/SPA: all modes of rendering supported**
3229
- Mobile first for the responsive web
3330
- Customizable navigation: scroll bar, buttons or basically everything
34-
- UX focused, smooth scrolling, snapping for variety of use case.
31+
- UX focused, smooth scrolling, snapping for a variety of use cases.
3532
- Small size of 3 KB for CDN users
36-
- Highly extensible for any use case with [well documented recipes](https://vue-horizontal.fuxing.dev/design/principles).
33+
- Highly extensible for any use case
34+
with [well documented recipes](https://vue-horizontal.fuxing.dev/design/principles).
3735
- You control how to structure your content with HTML
3836
- You control how it looks with CSS
3937
- You control how to navigate your layout with Vue.js
@@ -140,23 +138,19 @@ section {
140138

141139
### [CSS Scroll Behavior: Smooth](https://vue-horizontal.fuxing.dev/limitations#css-scroll-behavior-smooth)
142140

143-
In Vue Horizontal, smooth scrolling is enabled by default. With scroll-behavior: smooth, it enables smooth scrolling
141+
In Vue Horizontal, smooth scrolling is enabled by default. With `scroll-behavior: smooth`, it enables smooth scrolling
144142
experience when scroll event is triggered by programmatic calls. Although this is not a breaking functional feature, it
145-
provides a "smooth" scrolling user experience.
143+
provides a **"smooth"** scrolling user experience.
146144

147-
As of December 2020, there is only a 76% cross browser compatibility (88% if you include Safari experimental feature
148-
flag). Meantime you should polyfill this feature with more
149-
[information provided here](https://vue-horizontal.fuxing.dev/limitations#smoothscroll-polyfill). Polyfill should be
150-
done by the user, there are no plans to incorporate this natively in the library.
145+
As of December 2023, there is a 96% cross-browser compatibility.
151146

152147
### [CSS Scroll Snap](https://vue-horizontal.fuxing.dev/limitations#css-scroll-snap)
153148

154149
Scroll snap align or scroll-snapping, is a CSS technique that allows customizable scrolling experiences like pagination
155-
of carousels by setting defined snap positions. Vue Horizontal has it enabled by default, to disable you can set
156-
`<vue-horizontal snap="none">`.
150+
of carousels by setting defined snap positions. Vue Horizontal has it enabled by default to disable you can
151+
set `<vue-horizontal snap="none">`.
157152

158-
As of December 2020, there is a **94%+** cross browser compatibility. You can choose to polyfill this, but it's more of
159-
an aesthetic feature rather than a breaking functional requirement.
153+
As of December 2023, there is a 98% cross-browser compatibility.
160154

161155
## Development
162156

@@ -170,11 +164,11 @@ npm run cypress:run # e2e testing
170164

171165
- End-to-end test cases are also written because of the UI nature of this framework.
172166
[Cypress](https://www.cypress.io/) is used under the hood.
173-
- There are also additional integration testing done to ensure SSR and SSG works.
167+
- There is also additional integration testing done to ensure SSR and SSG works.
174168

175169
## Contributions
176170

177-
- For any question or feature request please feel free to create
171+
- For any question or feature request, please feel free to create
178172
an [issue](https://github.com/fuxingloh/vue-horizontal/issues/new)
179173
or [pull request](https://github.com/fuxingloh/vue-horizontal/pulls).
180174
- For feature request, do check out the examples as some of them might have been implemented.
@@ -194,4 +188,5 @@ This project is another take on it with an ultra simple implementation that is e
194188
to the user rather than the library.
195189

196190
## License
191+
197192
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Ffuxingloh%2Fvue-horizontal.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Ffuxingloh%2Fvue-horizontal?ref=badge_large)

0 commit comments

Comments
 (0)