Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame drops/freezes when opening BugSack with frequent long errors #34

Open
0xjc opened this issue Sep 11, 2020 · 0 comments
Open

Frame drops/freezes when opening BugSack with frequent long errors #34

0xjc opened this issue Sep 11, 2020 · 0 comments

Comments

@0xjc
Copy link

0xjc commented Sep 11, 2020

When an error occurs frequently (every frame) and the callstack context is long, opening BugSack can cause huge frame drops.

As a proof of concept if you import this WeakAura it will trigger an error every frame in a long function. Opening BugSack while the errors are still being generated freezes my game to <5 FPS. I know this is an artificial example but I have encountered this issue in the wild several times.

I have traced the issue to colorStack, which was taking 200ms/call with this example. Specifically this line:

ret = ret:gsub("([^\\]+%.lua)", "|cffffffff%1|r") -- Lua files

causes a lot of backtracking. Replacing it with

ret = ret:gsub("\\([^\\]+%.lua)", "\\|cffffffff%1|r") -- Lua files

fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant