Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cl-cookie? #88

Open
kilianmh opened this issue Jun 13, 2024 · 3 comments
Open

Integrate cl-cookie? #88

kilianmh opened this issue Jun 13, 2024 · 3 comments

Comments

@kilianmh
Copy link
Contributor

kilianmh commented Jun 13, 2024

Should we allow response:set-cookies slot in lack/response to be a instance of cl-cookie:cookie / cookie-jar? Then we could reuse cl-cookie:write-set-cookie-header for encoding the cookie-string.

@fukamachi
Copy link
Owner

It sounds reasonable.
Although I like Lack to be minimal, there's not much sense to reimplement it in Lack.

@kilianmh
Copy link
Contributor Author

kilianmh commented Jun 19, 2024

Should response:set-cookies be allowed to be of type cl-cookie:cookie-jar and cl-cookie:cookie, or only of the two?

Side note: Is there any specific reason, why to not allow (list of) cookie-strings as response:set-cookies value? See fukamachi/ningle#43

@fukamachi
Copy link
Owner

It's not required, but it's better to accept Common Lisp objects other than cl-cookie's objects if it doesn't make much trouble.

Side note: Is there any specific reason, why to not allow (list of) cookie-strings as response:set-cookies value? See fukamachi/ningle#43

No, I don't even remember the reason. I think an association list or hash table suits it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants