Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not detect any platforms warning #4239

Open
kerams opened this issue Dec 16, 2023 · 2 comments · May be fixed by #4258
Open

Could not detect any platforms warning #4239

kerams opened this issue Dec 16, 2023 · 2 comments · May be fixed by #4258

Comments

@kerams
Copy link
Contributor

kerams commented Dec 16, 2023

Description

Some packages use nonstandard (?) monikers in nuspec. AWSSDK.Core includes <group targetFramework=".NETCoreApp8.0" />, while Paket supposedly expects net8.0.

Repro steps

  • Create a net8.0 project
  • paket add AWSSDK.Core 3.7.300.4

Expected behavior

Package added cleanly.

Actual behavior

Warning Could not detect any platforms from '.netcoreapp8.0' in 'C:\Users\goof\.nuget\packages\awssdk.core\3.7.300.4\awssdk.core.nuspec', please tell the package authors, and I assume Paket then doesn't use the net8.0 assembly from the package.

Known workarounds

None.
@smoothdeveloper
Copy link
Contributor

https://learn.microsoft.com/en-us/nuget/reference/target-frameworks#supported-frameworks

yes it seems non standard.

Makes me wonder if we should have unit tests that scrape nuget.org (or basically, calls into the same code used there) to assert we match the same targets as shown on the page, nuget.org shows correct resolution.

@smoothdeveloper
Copy link
Contributor

https://github.com/NuGet/NuGetGallery/blob/e56384290f44bd4cc163cc94eff17bd3e63ac3c2/src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityFactory.cs#L47

@kerams kerams linked a pull request Jun 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recognize more platforms kerams/Paket
2 participants
@smoothdeveloper @kerams