Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie secret warning in app_server never used #432

Open
guynir42 opened this issue Jun 23, 2022 · 2 comments
Open

Cookie secret warning in app_server never used #432

guynir42 opened this issue Jun 23, 2022 · 2 comments
Assignees
@stefanv
Labels
bug Something isn't working

Comments

@guynir42
Copy link
Collaborator

The block of code in app_server.py warns the user that "Your server is insecure" is never reached.
I'm not sure if we should be checking against app.secret_key or instead of looking for cookie_secret inside cfg we should be looking for it under baselayer_settings.
I'm not sure what the logic should be, so I will leave it to @stefanv
@guynir42 guynir42 added the bug Something isn't working label Jun 23, 2022
@guynir42
Copy link
Collaborator Author

This is not an urgent bug.

@stefanv
Copy link
Contributor

stefanv commented Jun 23, 2022

Either should be fine. The cookie is copied into the app config, but probably more direct to check the config itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanv stefanv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanv @guynir42