Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record proxy server feature #34

Open
joanlopez opened this issue Oct 14, 2019 · 2 comments · May be fixed by #109
Open

Record proxy server feature #34

joanlopez opened this issue Oct 14, 2019 · 2 comments · May be fixed by #109
Assignees
@aperezg
Labels
enhancement New feature or request Hacktoberfest
Milestone
0.5.1

Comments

@joanlopez
Copy link
Member

(Straightly related with #33)

Context

A really very-well feature for Killgrave would be to be able to create "responses" (configuration) itself on-the-fly.

The idea is to let the user to configure only the imposter's request and then let Killgrave do the magic: fill the response section (within imposter) by going to the "real" implementation and getting the response.

Proposed implementation

That feature could be implemented on a two-steps development:

  • Firstly, developing a module responsible of that magic (able to create configuration from an HTTP response).
  • Secondly, allowing a new choice (record) for the proxy_server's mode configuration that would allow the user to enable that recording (just for the missing endpoints).
@joanlopez joanlopez added enhancement New feature or request Hacktoberfest labels Oct 14, 2019
@Darkclainer Darkclainer mentioned this issue Oct 16, 2019
Closed
@aperezg aperezg added this to the v0.5.0 milestone Oct 2, 2020
@donbachi
Copy link

donbachi commented Oct 6, 2020

Hi,
this sounds like a good issue for some first steps in killgrave.
If you don't mind, I would like to tackle this one.

BR,
donbachi

@joanlopez
Copy link
Member Author

Hi @donbachi,

I assigned you, so it's time to 🚀
Please, feel free to ping us if you have any doubt or need.

Thanks!!!

@joanlopez joanlopez removed the good first issue Good for newcomers label Feb 13, 2021
@joanlopez joanlopez assigned aperezg and unassigned donbachi Feb 13, 2021
@aperezg aperezg linked a pull request Oct 5, 2021 that will close this issue
Open
@aperezg aperezg linked a pull request Oct 10, 2021 that will close this issue
Proxy record #109
Open
@aperezg aperezg modified the milestones: v0.5.0, 0.5.1 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezg aperezg

Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
0.5.1
Development

Successfully merging a pull request may close this issue.

Proxy record friendsofgo/killgrave
3 participants
@donbachi @aperezg @joanlopez