Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox nightly shader compilation issue #840

Open
meepen opened this issue Jan 15, 2025 · 1 comment
Open

Firefox nightly shader compilation issue #840

meepen opened this issue Jan 15, 2025 · 1 comment

Comments

@meepen
Copy link

meepen commented Jan 15, 2025

Issue Template

Description

On Firefox Nightly 136.0a1 (2025-01-15) (64-bit), using GPU acceleration while using Relic Optimizer causes a shader compilation issue

Steps to Reproduce

  1. Use Firefox Nightly
  2. Go to https://fribbels.github.io/hsr-optimizer#main
  3. Select GPU Acceleration (stable)

Expected Behavior

No shader compilation issues

Actual Behavior

A shader compilation issue occurs,

Shader validation error: Function [42] 'calculateAshblazingSet' is invalid
     ┌─ :1784:1
     │  
1784 │ ╭ fn calculateAshblazingSet(
1785 │ │   p_x: ptr<function, ComputedStats>,
1786 │ │   p_state: ptr<function, ConditionalState>,
1787 │ │   hitMulti: f32,
     · │
1795 │ │ 
1796 │ │   return 0;
     │ │          ^ naga::Expression [23]
     │ ╰───────────^ naga::Function [42]
     │  
     = The `return` value Some([23]) does not match the function return value

Screenshots

image

Additional Information

I am aware Firefox Nightly is not a stable environment, and as such could cause issues that don't matter. I apologize if this is the case, but it was the only way to enable GPU acceleration via Firefox.

@fribbels
Copy link
Owner

Yeah this is unfortunately a known issue: https://github.com/fribbels/hsr-optimizer/blob/main/docs/guides/en/troubleshooting.md#error-gpu-acceleration-is-not-supported and we're awaiting a fix on Firefox's side. Their shader compilation method doesn't match the webgpu spec and hopefully will be updated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants