Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide max/avg potential for characters that will not use a relic #477

Open
thailyn opened this issue Jul 11, 2024 · 1 comment
Open

Comments

@thailyn
Copy link

thailyn commented Jul 11, 2024

Motivation

When looking at the relic insights graph or the max/avg potential columns on the relic tab, all of the suitable characters are shown or factored in, regardless of whether they are configured to use that relic set on the optimize tab. This can lead to the user thinking a relic might be an upgrade for a character, but actually the optimizer will never select it, or having a relic insights graph that is cluttered with irrelevant characters.

Goal

For the relic table columns "Selected Char Avg/Max Potential" and similar columns, do not include a character's potential in the calculations unless that character is configured to use that set on the optimize tab (or if the character is not in the character list, or the character has no sets selects on the optimize tab at all).

For the relic insights graph, do not show icons (for buckets) or rows (for top 10) for characters that are not configured to use that relic's set on the optimize tab (or, those other conditions mentioned above). If not showing them at all is not ideal, perhaps these could be just grayed out or otherwise have some indication that those characters do not use that relic set.

Obviously, this additional filtering can be behind a toggle or as new columns in the table, etc., if that is deemed more appropriate.

@thailyn
Copy link
Author

thailyn commented Jan 2, 2025

I recently realized/remembered that, on the Relics tab, if a relic's main stat does not match one of the specified "Optimal mainstats" in the "Scoring algorithm" popup, that relic will always have a 0% average and max potential for that character.

From this, I thought of another potential way to implement this feature request. The "Scoring algorithm" popup could be expanded to also include (for example) checkboxes for each relic set and planetary ornament, and all relics not selected always have a 0% average for that character. There could be another checkbox to enable/disable filtering by sets, or perhaps if none are selected this feature would be disabled. (Obviously, an array of checkboxes is not the ideal way to expose this setting in the UI, but I think the intended capabilities of such a feature is clear.)

As mentioned in #710 , having a feature like this would greatly benefit from maintaining a list of "optimal" sets for each character on your end, similar to how each character has default values for stat weights and optimal mainstats. However, I am one of those players who fills in the relic set filter on the optimizer tab for all of my characters (it's part of the fun, really). Personally, it would be perfectly acceptable if the list of "optimal" sets is [initially] empty and I would need to fill in the data.

The benefit of easily knowing which relics truly are suitable for a character at a glance, and more accurately knowing which are trash for anyone who would use it (so I can stop my relic hoarding please send help), would vastly outweigh the small amount of bookkeeping I would have to do on my end to keep the optimal sets up to date. (I'm already doing that on the optimizer tab, anyway!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant