Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nftables #321

Open
fbuetler opened this issue Feb 20, 2023 · 2 comments
Open

Support for nftables #321

fbuetler opened this issue Feb 20, 2023 · 2 comments
Assignees
@fbuetler
Labels
enhancement New feature or request

Comments

@fbuetler
Copy link

At the moment only iptables are supported and it would be nice if nftables were supported as well.
@awlx
Copy link
Member

awlx commented Feb 23, 2023 •
edited
Loading

@DasSkelett maybe we can switch to use netlink for nftables programming that's even possible on machines which don't have nftables binaries.

https://github.com/google/nftables

@DasSkelett
Copy link
Member

Yeah I tried adding nftables support with that library in the past, but in the end the rule building was too low-level for my liking, see for example:
https://github.com/siderolabs/talos/blob/dea17d72340b1deddea2215b556a4f193d1feb7f/internal/app/machined/pkg/controllers/kubespan/nftables.go#L181-L223

I might give it another triy, but it will definitely decrease maintainability and expandability of this part of the code.

@DasSkelett DasSkelett added the enhancement New feature or request label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbuetler fbuetler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@awlx @DasSkelett @fbuetler