Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Change request library #9

Open
morris opened this issue May 16, 2019 · 2 comments
Open

Change request library #9

morris opened this issue May 16, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@morris
Copy link
Contributor

morris commented May 16, 2019

request is dying: request/request#3142

@morris morris added enhancement New feature or request good first issue Good for newcomers labels May 16, 2019
@vladotesanovic
Copy link

@morris

Is this assigned to anyone?

I would like to test this library, and maybe i can do this change to code for you.

What library you planned to use instead?

@morris
Copy link
Contributor Author

morris commented May 21, 2019

Hi! No, it's not assigned, feel free to take a shot. I haven't researched for libraries yet; I believe we'd need a library which is promise-based and accepts options via an object (so we can do options merging, useful in config etc.)

Signature should be something like request({ method: "...", url: "...", headers: { ... }, ... }): Promise<any>. Ideally, it should throw on 4xx, 5xx. Optionally, it should follow redirects.

I'd be open to use a library which doesn't follow the requirements I described, as long as we can define a wrapper function with the signature mentioned above.

Thanks for your interest :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants