From 290a7be453f1e445c6c8b0a8aaf3e145afd028a2 Mon Sep 17 00:00:00 2001
From: Jan Pazdziora <jpazdziora@redhat.com>
Date: Sat, 19 Oct 2024 12:35:31 +0200
Subject: [PATCH] Workaround some skopeo / docker incompatibility, just use the
 locally saved image.

Addressing
level=fatal msg="Error parsing image name \"docker-daemon:localhost/freeipa-server:fedora-40\": loading image from docker engine: Error response from daemon: {\"message\":\"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version\"}"
---
 .github/workflows/build-test.yaml | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/build-test.yaml b/.github/workflows/build-test.yaml
index 1b32508a..3708a11e 100644
--- a/.github/workflows/build-test.yaml
+++ b/.github/workflows/build-test.yaml
@@ -45,18 +45,6 @@ jobs:
               "body": "This issue was automatically created by GitHub Action\n\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}.\n",
               "labels": ["image-build-fail" ]
               }'
-      - name: Check resulting labels
-        run: |
-          skopeo inspect docker-daemon:localhost/freeipa-server:${{ matrix.os }} | jq '.Labels'
-          diff -u <( skopeo inspect docker://quay.io/freeipa/freeipa-server:${{ matrix.os }} | jq '.Labels' ) <( skopeo inspect docker-daemon:localhost/freeipa-server:${{ matrix.os }} | jq '.Labels' ) || true
-        shell: bash
-        if: matrix.docker != 'podman'
-      - name: Check resulting labels
-        run: |
-          skopeo inspect containers-storage:localhost/freeipa-server:${{ matrix.os }} | jq '.Labels'
-          diff -u <( skopeo inspect docker://quay.io/freeipa/freeipa-server:${{ matrix.os }} | jq '.Labels' ) <( skopeo inspect containers-storage:localhost/freeipa-server:${{ matrix.os }} | jq '.Labels' ) || true
-        shell: bash
-        if: matrix.docker == 'podman'
       - name: Create directory for artifacts
         run: mkdir freeipa-server-${{ matrix.os }}
       - name: Save image
@@ -66,6 +54,11 @@ jobs:
           name: freeipa-server-${{ matrix.os }}
           path: freeipa-server-${{ matrix.os }}
           retention-days: 1
+      - name: Check resulting labels
+        run: |
+          skopeo inspect docker-archive:freeipa-server-${{ matrix.os }}/freeipa-server-${{ matrix.os }}.tar.gz | jq '.Labels'
+          diff -u <( skopeo inspect docker://quay.io/freeipa/freeipa-server:${{ matrix.os }} | jq '.Labels' ) <( skopeo inspect docker-archive:freeipa-server-${{ matrix.os }}/freeipa-server-${{ matrix.os }}.tar.gz | jq '.Labels' ) || true
+        shell: bash
 
   test-docker:
     name: Run with docker