Skip to content

Add a bottom margin to ControlLabel #161

Closed
@huyenltnguyen

Description

@huyenltnguyen

Description

I found that ControlLabel (renders a label) doesn't have a bottom margin, and it sits right above the input when combined with FormControl:

<FormGroup>
  <ControlLabel>Name</ControlLabel>
  <FormControl type="text" />
</FormGroup>

We are currently getting a bottom margin in /learn thanks to Bootstrap: https://github.com/twbs/bootstrap/blob/f17f882df292b29323f1e1da515bd16f326cee4a/dist/css/bootstrap.css#L2609.

I think either ControlLabel should have a bottom margin of 5px, or the FormGroup component should add a space of 5px between its children.

Metadata

Metadata

Assignees

Labels

release: majorChanges that would go in a major release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions