Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords stored in plain text #107

Open
anorwood-xten opened this issue Nov 7, 2021 · 5 comments
Open

Passwords stored in plain text #107

anorwood-xten opened this issue Nov 7, 2021 · 5 comments

Comments

@anorwood-xten
Copy link

Hi team,

Noted that when defining the data source the username and password are being stored in clear text. Do you have any experience with pulling the username and/or password from a secure source (a Vault, for example)? There are obvious security concerns with keeping passwords in plaintext (even if it's on a yaml file on our infra)

Thanks!

@mlybarger
Copy link

raising this up again.

@thaddak
Copy link

thaddak commented Mar 22, 2023

I adapted the code to encrypt the entire dsn. The code is below.

https://github.com/thaddak/sql_exporter

@mlybarger
Copy link

this looks promising @thaddak , we will be trying this out. have you considered a MR/PR to the main repo? or forking the repo itself if it's not maintained?

@thaddak
Copy link

thaddak commented Mar 22, 2023 via email

@mlybarger
Copy link

mlybarger commented Mar 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants