Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Empty space with missing components #13

Open
samukhin opened this issue Nov 3, 2024 · 1 comment
Open

[BUG] Empty space with missing components #13

samukhin opened this issue Nov 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@samukhin
Copy link

samukhin commented Nov 3, 2024

Describe the bug
With missing notification and bluetooth or network-manager components, parts of the interface are missing and look ugly.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a bare installation without bluetooth and notifications
  2. Click on menu
  3. Launch and see what is in the screenshot (white and black squares)

Expected behavior
Remove inaccessible elements when a conflict is detected.

Screenshots
Screenshot From 2024-11-03 18-36-28

Additional context
Using the same steps as on a real PC, it was not possible to build veshell on a virtual machine (VirtualBox and VmWare).
UPDATE: I was able to run it on VirtualBox in Debian 12, but it didn’t work in Arch and Fedora
UPDATE: I was able to do everything, but it’s better to make instructions

@samukhin samukhin added the bug Something isn't working label Nov 3, 2024
@samukhin
Copy link
Author

samukhin commented Nov 3, 2024

image

Temporary solution for my case:

[user@PC veshell]$ git diff
diff --git a/shell/lib/overview/helm/control_panel/widget/control_panel.dart b/shell/lib/overview/helm/control_panel/widget/control_panel.dart
index c3717da..a2856b5 100644
--- a/shell/lib/overview/helm/control_panel/widget/control_panel.dart
+++ b/shell/lib/overview/helm/control_panel/widget/control_panel.dart
@@ -76,7 +76,7 @@ class ControlPanel extends StatelessWidget {
               ), */
               AudioOutputWidget(),
               NetworkControl(),
-              BluetoothControl(),
+              /*BluetoothControl(),*/
             ],
           ),
         ),
diff --git a/shell/lib/overview/helm/widget/helm.dart b/shell/lib/overview/helm/widget/helm.dart
index d3dda74..77aa0db 100644
--- a/shell/lib/overview/helm/widget/helm.dart
+++ b/shell/lib/overview/helm/widget/helm.dart
@@ -14,7 +14,7 @@ class Helm extends HookConsumerWidget {
         SizedBox(width: 8),
         Expanded(child: MonitoringPanel()),
         SizedBox(width: 8),
-        Expanded(child: NotificationPanel()),
+        /*Expanded(child: NotificationPanel()),*/
       ],
     );
   }
[user@PC veshell]$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant