Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if there are a lot of open PRs #120

Open
pbrisbin opened this issue Jan 19, 2024 · 1 comment
Open

Error if there are a lot of open PRs #120

pbrisbin opened this issue Jan 19, 2024 · 1 comment

Comments

@pbrisbin
Copy link
Member

If there a lot of open PRs, we can hit a rate limit:

  Un-halting all open PRs
  Setting un-halted status for PR #32409
  Setting un-halted status for PR #32408
  Setting un-halted status for PR #32406
  Setting un-halted status for PR #32405
  Setting un-halted status for PR #32403
  Setting un-halted status for PR #32401
  Setting un-halted status for PR #32400
  Setting un-halted status for PR #32399
  Setting un-halted status for PR #32398
  Setting un-halted status for PR #32397
  Setting un-halted status for PR #32392
  Setting un-halted status for PR #32391
  Setting un-halted status for PR #32390
  Setting un-halted status for PR #32388
  Setting un-halted status for PR #32387
  Setting un-halted status for PR #32386
  Setting un-halted status for PR #32385
  Setting un-halted status for PR #32384
  Setting un-halted status for PR #32383
  Setting un-halted status for PR #32381
  Setting un-halted status for PR #32380
  Setting un-halted status for PR #32379
  Setting un-halted status for PR #32378
  Setting un-halted status for PR #32377
  Setting un-halted status for PR #32376
  Setting un-halted status for PR #32373
  Setting un-halted status for PR #32372
  Setting un-halted status for PR #32371
  Setting un-halted status for PR #32369
  Setting un-halted status for PR #32367
  Setting un-halted status for PR #32363
  Setting un-halted status for PR #32362
  Setting un-halted status for PR #32360
  Setting un-halted status for PR #32358
  Setting un-halted status for PR #32357
  Setting un-halted status for PR #32356
  Setting un-halted status for PR #32355
  Setting un-halted status for PR #32351
  Setting un-halted status for PR #32350
  Setting un-halted status for PR #32347
  Setting un-halted status for PR #32338
  Setting un-halted status for PR #32331
  Setting un-halted status for PR #32328
  Setting un-halted status for PR #32325
  Setting un-halted status for PR #32324
  Setting un-halted status for PR #32321
  Setting un-halted status for PR #32314
  Setting un-halted status for PR #32312
  Setting un-halted status for PR #32311
  Setting un-halted status for PR #32308
  Setting un-halted status for PR #32305
  Setting un-halted status for PR #32293
  Setting un-halted status for PR #32292
  Setting un-halted status for PR #32285
  Setting un-halted status for PR #32276
  Setting un-halted status for PR #32264
  Setting un-halted status for PR #32250
  Setting un-halted status for PR #32213
  Setting un-halted status for PR #32200
  Setting un-halted status for PR #32199
  Setting un-halted status for PR #32197
  Setting un-halted status for PR #32193
  Setting un-halted status for PR #32174
  Setting un-halted status for PR #32171
  Setting un-halted status for PR #32148
  Setting un-halted status for PR #32143
  Setting un-halted status for PR #32128
  Setting un-halted status for PR #32127
  Setting un-halted status for PR #32106
  Setting un-halted status for PR #32095
  Setting un-halted status for PR #32063
  Setting un-halted status for PR #32052
  Setting un-halted status for PR #31992
  Setting un-halted status for PR #31986
  Setting un-halted status for PR #31984
  Setting un-halted status for PR #31976
  Setting un-halted status for PR #31975
  Setting un-halted status for PR #31971
  Setting un-halted status for PR #31939
  Setting un-halted status for PR #31910
  Setting un-halted status for PR #31907
  Setting un-halted status for PR #31797
  Setting un-halted status for PR #31795
  Setting un-halted status for PR #31794
  Setting un-halted status for PR #31793
  Setting un-halted status for PR #31778
  Setting un-halted status for PR #31774
  Setting un-halted status for PR #31766
  Setting un-halted status for PR #31715
  Setting un-halted status for PR #31714
  Setting un-halted status for PR #31668
  Setting un-halted status for PR #31667
  Setting un-halted status for PR #31666
  Setting un-halted status for PR #31665
  Setting un-halted status for PR #31664
  Setting un-halted status for PR #31663
  Setting un-halted status for PR #31662
  Setting un-halted status for PR #31661
  Setting un-halted status for PR #31660
  Setting un-halted status for PR #31659
  Setting un-halted status for PR #31658
  Setting un-halted status for PR #31657
  Setting un-halted status for PR #31656
  Setting un-halted status for PR #31655
  Setting un-halted status for PR #31654
  Setting un-halted status for PR #31651
  Setting un-halted status for PR #31648
  Setting un-halted status for PR #31606
  Setting un-halted status for PR #31571
  Setting un-halted status for PR #31417
  Setting un-halted status for PR #31380
  Setting un-halted status for PR #31355
  Setting un-halted status for PR #31314
  Setting un-halted status for PR #31283
  Setting un-halted status for PR #31163
  Setting un-halted status for PR #31126
  Setting un-halted status for PR #31072
  Setting un-halted status for PR #31010
  Setting un-halted status for PR #30889
  Setting un-halted status for PR #30850
  Setting un-halted status for PR #30811
  Setting un-halted status for PR #30719
  Setting un-halted status for PR #30645
  Setting un-halted status for PR #30625
  Setting un-halted status for PR #30592
  Setting un-halted status for PR #30591
  Setting un-halted status for PR #30315
  Setting un-halted status for PR #30305
  Setting un-halted status for PR #30189
  Setting un-halted status for PR #30131
  Setting un-halted status for PR #30130
  Setting un-halted status for PR #29948
  Setting un-halted status for PR #29642
  Setting un-halted status for PR #29265
  Setting un-halted status for PR #29176
  Setting un-halted status for PR #28680
  Setting un-halted status for PR #28580
  Setting un-halted status for PR #28446
  Setting un-halted status for PR #27917
  Setting un-halted status for PR #27831
  Setting un-halted status for PR #27443
  Setting un-halted status for PR #27420
  Setting un-halted status for PR #27249
  Setting un-halted status for PR #26982
  Setting un-halted status for PR #26641
  Setting un-halted status for PR #26407
  Setting un-halted status for PR #25943
  Setting un-halted status for PR #25890
  Setting un-halted status for PR #25701
/home/runner/work/_actions/freckle/halt-action/v1/dist/index.js:6402
      const error = new requestError.RequestError(toErrorMessage(data), status, {
                    ^

RequestError [HttpError]: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID ECBD:58A8:6BF21B3:DF5CF77:65AAA0E5.

The action could be made a little more efficient. Right now, it just un-halts all open PRs; it doesn't check to see if there is currently a red halt status first. If we did check that, it may still fail the first time around, but would at least make progress and eventually succeed on retries.

And/or we could add a catch-wait-retry around it.

@pbrisbin
Copy link
Member Author

would at least make progress and eventually succeed on retries

We could probably achieve this easier by just randomizing the order in which we process the open PRs. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant