Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"# of Teams Lifted" Data Issues #11

Open
Spazdiesfirst360 opened this issue Feb 14, 2019 · 2 comments
Open

"# of Teams Lifted" Data Issues #11

Spazdiesfirst360 opened this issue Feb 14, 2019 · 2 comments
Labels
important Something important

Comments

@Spazdiesfirst360
Copy link
Contributor

Spazdiesfirst360 commented Feb 14, 2019 •
edited
Loading

Some entries for "# of Teams Lifted" are showing as NaN, and the rest show as 0 despite having data saying otherwise.

This issue started with commit 66d6507
@Spazdiesfirst360 Spazdiesfirst360 pinned this issue Feb 14, 2019
@Spazdiesfirst360 Spazdiesfirst360 unpinned this issue Feb 14, 2019
@Spazdiesfirst360 Spazdiesfirst360 added bug Something isn't working invalid This doesn't seem right labels Feb 14, 2019
@ariovistus
Copy link
Contributor

clearly, you should write a unit test

@Spazdiesfirst360
Copy link
Contributor Author

clearly, you should write a unit test

No need to.
A scouted match had an input of either null or undefined for "# of Teams Lifted"
This should be mentioned to users.

@Spazdiesfirst360 Spazdiesfirst360 added important Something important and removed bug Something isn't working invalid This doesn't seem right labels Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important Something important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ariovistus @Spazdiesfirst360