Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow multiple Product Bundle for the same item #45925

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

feat: Allow multiple Product Bundle for the same item #45925

wants to merge 20 commits into from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Feb 14, 2025 •
edited
Loading

Closes #29462

Should be mostly backwards compatible, waiting for tests to pass.

no-docs

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. selling stock labels Feb 14, 2025
@cogk cogk force-pushed the feat-product-bundle-versioning branch from 4409ee3 to d1f54e1 Compare February 14, 2025 15:13
@cogk cogk force-pushed the feat-product-bundle-versioning branch from 63ebe67 to c162479 Compare February 20, 2025 18:40
cogk
cogk commented Feb 27, 2025
View reviewed changes
Copy link
Contributor Author

@cogk cogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Handle update_child_qty_rate, reset_packing_list

@cogk cogk marked this pull request as draft February 27, 2025 16:38
cogk added 18 commits February 28, 2025 20:09
@cogk
refactor(bundle): Handle in Packed Item
e00410a
@cogk
refactor(bundle): Handle in POS
ac44c4c
@cogk
refactor(bundle): Handle in selling/Sales Order
b58ea77
@cogk
refactor(bundle): Handle in Pick List
f0f42dc
@cogk
refactor(bundle): Add missing fields
5b7c59f
@cogk
refactor(bundle): Set product bundle of item row on save
68b31c7
@cogk
refactor(bundle): Add random suffix to autoname
68dcfc4
@cogk
fix: Product Bundle Balance report for multi-version bundles
e46a355
@cogk
fix(bundle): Use product_bundle_name if available
e9f4d50
@cogk
fix(bundle): Fix product_bundle_name value when changing item_code
49927dc
@cogk
test: Allow merging Items even if they have product bundles
da472dc
@cogk
fix: Don't return disabled bundles
aae4ea3
@cogk
refactor: Add as_name param to is_product_bundle
5cd87c1
@cogk
fix: Return only latest bundle in get_product_bundle_items if no name…
043a98f 
… given
@cogk
fix: Set product bundle in update_child_qty_rate
a0cc381
@cogk
fix: Validate product bundle in update_child_qty_rate
5140db1
@cogk
fix: Detect changes to product_bundle_name in make_packing_list
249eb23
@cogk
refactor: Rename to get_product_bundle_name
89bfd0a
@cogk cogk force-pushed the feat-product-bundle-versioning branch from c162479 to 594d735 Compare February 28, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests. selling stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

product bundle should be a submittable i.e. versioned document
1 participant
@cogk