Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Module and Adapter as root elements #93

Open
jacodg opened this issue Mar 23, 2022 · 2 comments
Open

Remove Module and Adapter as root elements #93

jacodg opened this issue Mar 23, 2022 · 2 comments

Comments

@jacodg
Copy link

jacodg commented Mar 23, 2022

It would be easier for users to always use the same root element and have no need to adjust the root element based on the use case. See description in the Frank!Runner README for the current three options:

https://github.com/ibissource/frank-runner#code-completion-with-frankconfigxsd

So I would like to suggest to remove the possibility to have Module and Adapter as root elements and allow a Configuration element in a Configuration element for the use case where one configuration file is included in another configuration file using an entity reference. Only one include level is enough in my opinion (no need to recursively include a Configuration in a Configuration).

This also means F!F needs to be adjusted to be able to parse a Configuration element in a Configuration element when initializing a configuration. Ask Gerrit and/or Niels to look into this when you change the Frank!Doc for this.

@philipsens
Copy link
Member

@ibissource/frank-doc What's the progress on this?

@mhdirkse
Copy link
Contributor

mhdirkse commented Feb 2, 2024

I saw that <Receiver>, <Param> and many more are allowed as root elements at the moment. I think this issue entails that these should no longer be available as root elements, only <Configuration>, <Module> and <Adapter>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants