Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all frank elements are in the Frank!Doc #45

Open
nielsm5 opened this issue Nov 26, 2021 · 3 comments
Open

Not all frank elements are in the Frank!Doc #45

nielsm5 opened this issue Nov 26, 2021 · 3 comments

Comments

@nielsm5
Copy link
Member

nielsm5 commented Nov 26, 2021

Right now only elements that are a child of a root element are included in the Frank!Doc. Because of this the framework now contains lots of dummy methods such as:

// Dummy setter to allow JmsRealms being added to Configurations via FrankDoc.xsd
public void registerJmsRealm(JmsRealm realm) {
	JmsRealmFactory.getInstance().registerJmsRealm(realm);
}

// Dummy method to include monitoring in the Frank!Doc.
public void registerMonitoring(MonitorManager factory) {
}

In order to avoid these methods I propose that we change the required rules in the digester-rules.xml from relative to absolute paths.

From:
<rule pattern="*/monitoring" registerMethod="registerMonitoring" factory="nl.nn.adapterframework.monitoring.MonitoringFactory"/>
To:
<rule pattern="configuration/monitoring" factory="nl.nn.adapterframework.monitoring.MonitoringFactory"/>

Note the absolute path/pattern, enforcing this element to be a child of Configuration, even though there is no setter available for this element.

@nielsm5
Copy link
Member Author

nielsm5 commented Nov 26, 2021

See frankframework/frankframework#2471 where the above change has been made.

@mhdirkse
Copy link
Contributor

The Frank!Doc needs to know a Java class or interface for the child. If it is not the argument of a set/add/register method, how should the Frank!Doc know it?

@nielsm5
Copy link
Member Author

nielsm5 commented Dec 1, 2021

I've updated the abovementioned pull request. I hope the changes made in the digester-rules.xml file will suffice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants