Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunity for code cleanup in FrankDocModel.createAttributes() #178

Open
mhdirkse opened this issue Mar 5, 2024 · 2 comments
Open

Opportunity for code cleanup in FrankDocModel.createAttributes() #178

mhdirkse opened this issue Mar 5, 2024 · 2 comments
Assignees
Labels

Comments

@mhdirkse
Copy link
Contributor

mhdirkse commented Mar 5, 2024

Two tasks of this method can be removed:

  1. Currently, a getter that accompanies an attribute setter is used for type checking. The return type of the getter is compared with the argument type of the setter. This check becomes irrelevant because getters may be hidden. Getters that are done with Lombok @Getter will not be visible when the de-lombok step is out of the F!F build.
  2. Attributes of an enum type will always have the enum as argument type. The check for getXxxEnum() to find the enum type will become irrelevant and can be removed.

See frankframework/frankframework#6344.

@jkosternl
Copy link
Contributor

jkosternl commented Mar 6, 2024

A lot of information is lost if we don't delombok our code, because the Javadoc tool does not use the lombok plugin to do annotation processing. The XSD diff which I tested only on the core module code had about 500 lines of differences. The current solution is in the PR, keeping the delombok step.

If number 2 (enum attributes) does not make sense anymore, feel free to do that activity. Please compare the output XSD on the master, to see if no (real) differences are there.

@jkosternl
Copy link
Contributor

Just discussed with Niels: number 2 is OK to perform, so if you have some time for that, that's ok. 👍🏻
Number 1 should stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

3 participants