Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to catogorize forwards #137

Closed
philipsens opened this issue Oct 17, 2022 · 2 comments
Closed

Make it possible to catogorize forwards #137

philipsens opened this issue Oct 17, 2022 · 2 comments

Comments

@philipsens
Copy link
Member

philipsens commented Oct 17, 2022

This request comes from an issue in the Frank!Flow (frankframework/frank-flow#716). They want to show different colors for the different types of forwards.

They could just implement a list within the Frank!Flow, but that would make it possible to overlook new forwards. Implementing this in the Frank!Doc would make it future-proof.

@jjansenvr has made a list of forwards and the categories they belong to:

When thinking about the placing algorithm i found I needed to sort the edges(forwards) to have the happiest flow on top

this is the ordering I use:
success 1
then 2
{any unknown forward (fe from switch} 3
else 4
equals 5
lessthan 6
greaterthan 7
warnings 8
outputWarnings 9
failure 10
outputFailure 11
antiVirusFailed 12
filenotfound 13
notInRole 14
passwordProtected 15
noConversionForwardName 16
exception 17
parserError 18
outputParserError 19

It might be an idea to group the forwards and given them a color:
1 t/m 7 green (succes)
8 t/m 9 yellow (warning)
10 t/m 16 orange (failure)
17 t/m 19 red (exception)

Originally posted by @jjansenvr in frankframework/frank-flow#716 (comment)

@Matthbo
Copy link
Member

Matthbo commented Feb 25, 2025

Is this still a thing we want with the new Doc and Flow designs?

@nielsm5
Copy link
Member

nielsm5 commented Mar 3, 2025

Is this still a thing we want with the new Doc and Flow designs?

No, it's too confusing to add different colors for the forwards.

@nielsm5 nielsm5 closed this as completed Mar 3, 2025
@nielsm5 nielsm5 self-assigned this Mar 3, 2025
@philipsens philipsens closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants