Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Product - Add tax_code as a resource definition parameter #66

Open
vschmidt-evo opened this issue Sep 19, 2022 · 0 comments
Open

Comments

@vschmidt-evo
Copy link

To help support the ability to automatically collect taxes from the prices of products that make up a description, it would be helpful if the resource definition of a stripe_product could include the tax_code property.

Sample request POST body that features a tax_code

{
  "description": "",
  "metadata": {
    "some_key": "some_value"
  },
  "statement_descriptor": "",
  "images": "",
  "tax_code": "txcd_10000000",
  "feature_list": "",
  "unit_label": "",
  "name": "My Test Product"
}

Updating the stripe/resource_stripe_product.go file with something like

			"tax_code": &schema.Schema{
				Type:     schema.TypeString,
				Optional: true,
			},

Then updating the create, read, and update functions accordingly.

The biggest challenge I see here is if a developer inputs an invalid tax code, Stripe might yell and give a 400 error, but that should be caught when the client calls to create a new product? It's kind of up to the developer to search Stripe and figure out the tax code they want to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant