Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadcn/cli compatability #42

Open
debuggingfuture opened this issue Dec 2, 2024 — with Huly for GitHub · 1 comment
Open

shadcn/cli compatability #42

debuggingfuture opened this issue Dec 2, 2024 — with Huly for GitHub · 1 comment
Assignees

Comments

Copy link
Member

debuggingfuture commented Dec 2, 2024

Huly®: DAPPK-43

@debuggingfuture debuggingfuture self-assigned this Dec 2, 2024
@debuggingfuture
Copy link
Member Author

debuggingfuture commented Dec 23, 2024

problem statements

  • We want to use different paths for built in shadcn components vs geist components
  • We want to avoid maintain copy / submodule of original shadcn
  • We need nested components

Current approach

  • Modified from build-registry.mts
  • support shadcnRegistries to remap deps
  • support nested folder

turn out we need to maintain dependencies in registry-ui.ts etc quite explicitly as in shadcn

for now it is better to stack with namespacing components with snake case in file name over nested folder
e.g. identity_address-badge

seems shadcn do not have good support for nested folder e.g. ui/identity/address-badge.tsx

  • using name as identity/address-badge we're able to generate the .json and folders,
    however at install it will be ignored and always write to ui/address-badge.tsx

target field in generated .json can override that but it is very forceful and do not honour the alias configured in componetns.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant