Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[placeholder] Update edits of user groups #747

Open
tcompa opened this issue Nov 21, 2024 · 0 comments · May be fixed by #748
Open

[placeholder] Update edits of user groups #747

tcompa opened this issue Nov 21, 2024 · 0 comments · May be fixed by #748
Assignees

Comments

@tcompa
Copy link
Collaborator

tcompa commented Nov 21, 2024

(not yet implemented in the backend, I will update this issue when it is)

In the current status:

  • We cannot remove users from a user group
  • Adding users to a user groups is meant to also work for the "bulk" case, even though we only add one user at a time in the current fractal-web UI.

As soon as fractal-analytics-platform/fractal-server#1841 (starting from fractal-analytics-platform/fractal-server#1841 (comment)) is implemented and released, two things will change:

  • The current way of adding users will be deprecated
  • There will be two more atomic endpoints that add/remove a single user and then return the updated group object:
POST /group/{group_id}/add-user/{user_id}/
POST /group/{group_id}/remove-user/{user_id}/

Relevant PR:


Side-note: we are leaving the possibility of bulk user addition/removal for the future, and it may eventually be part of POST /auth/group/{user_group_id}/add-users-bulk/ and POST /auth/group/{user_group_id}/remove-users-bulk/.

@ychiucco ychiucco linked a pull request Nov 25, 2024 that will close this issue
1 task
@ychiucco ychiucco linked a pull request Nov 25, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants