Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for '.' in the bucket name and produce an error message if needed #7

Open
dack-fe opened this issue Dec 29, 2020 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@dack-fe
Copy link
Contributor

dack-fe commented Dec 29, 2020

The web app is not able to parse . in the bucket name correctly, even though this is a valid S3 bucket name

image

@dack-fe dack-fe added the bug Something isn't working label Dec 29, 2020
@tvannoy
Copy link
Member

tvannoy commented Dec 29, 2020

As mentioned in the email thread, using . in bucket names is not suggested. From the AWS documentation:

If you include dots in a bucket's name, you can't use virtual-host-style addressing over HTTPS, unless you perform your own certificate validation. This is because the security certificates used for virtual hosting of buckets don't work for buckets with dots in their names.

Judging by the screen capture in this issue, we are using virtual-host-style addressing over https, which is why we are getting a certificate error. We could technically use buckets with . in their names if we used path-style requests, but path-style requests are being deprecated.

It looks like we basically need to not use . in bucket names.

@dack-fe
Copy link
Contributor Author

dack-fe commented Dec 29, 2020

@tvannoy I agree the best practice is to no use . in bucket names. I think we should update our documentation to specify that we don't support . and have the web app provide an error message if it detects . in the bucket name.

@dack-fe dack-fe added enhancement New feature or request and removed bug Something isn't working labels Dec 29, 2020
@fe-wickham fe-wickham changed the title Web App doesn't parse '.' in the bucket name Check for '.' in the bucket name and produce an error message if needed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants