KOL-81 Ensure the Solana tests are run in CI #486
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borsboom
force-pushed
the
KOL-81-solana-bridge-tests
branch
from
581c401 to
7641321
Compare
Deploying kolme with
|
| Latest commit: |
b9df476
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f62b11dc.kolme.pages.dev |
| Branch Preview URL: | https://kol-81-solana-bridge-tests.kolme.pages.dev |
borsboom
force-pushed
the
KOL-81-solana-bridge-tests
branch
from
7641321 to
b9df476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CI job matrix for the two solana-bridge tests. I'm not sure if we'll ultimately want to keep these as separate jobs, but since they are currently not working properly, and since I've experienced some non-deterministic behaviour locally, I figure keeping them completely independent is a good starting point.
The
bridge_transfertest fails, while thesolana_listener_catchuptest just hangs without ever completing. I set a 25 minute timeout on the test so we don't waste CI minutes (the default timeout is six hours).I don't think this PR should be merged until the tests are succeeding, but we could consider setting
continue-on-error: trueif we want to merge before then.A few other changes I made:
solana/justfileand improved the way it waits for it to start up by polling until it's accepting connections.packages/integration-tests/solana-bridge-tests.shto use the justfile to start solana-test-validator, and to return the correct exit code by moving cleanup into an EXIT trap.workflow_dispatchtrigger to the CI workflow so that runs can be manually started from the Github CLI or UI.