Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless reload of the page #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid useless reload of the page #21

wants to merge 2 commits into from

Conversation

laulaz
Copy link
Contributor

@laulaz laulaz commented Mar 18, 2019

We had a UX issue with page reloading after cookie acceptation.
After reading the code, we don't understand why the page had to be reloaded to activate cookies.
It's working fine without that reload.

Can you please merge this PR or explain the edge case you were wanting to handle with that reload ?

laulaz added a commit to IMIO/buildout.website that referenced this pull request Mar 21, 2019
@laulaz
Copy link
Contributor Author

laulaz commented Apr 5, 2019

@kingel @ralphjacobs could you please take a look at this PR ?

@kingel
Copy link
Member

kingel commented Apr 5, 2019

@laulaz We don't do a lot of active plone development anymore, if you want I could give you access to the repo and to pypi

@laulaz
Copy link
Contributor Author

laulaz commented Apr 5, 2019

@kingel Thank you for your quick answer !
I'm OK to have Pypi access (user : laz).
For the repo, would you mind to transfer it to collective organization to get more maintainers / developers working on it ? Otherwise, I'm OK with access to repo ;-)

Thanks a lot !

@kingel
Copy link
Member

kingel commented Apr 5, 2019

@laulaz github promised to take the pr's and issues as well but no go.. I moved it to https://github.com/collective/collective.cookiecuttr so maybe you can redo your pr

I added you on pypi

@laulaz
Copy link
Contributor Author

laulaz commented Apr 5, 2019

@kingel

I added you on pypi

Thanks !

@laulaz github promised to take the pr's and issues as well but no go.. I moved it to https://github.com/collective/collective.cookiecuttr so maybe you can redo your pr

Did you Transfer it ? it's strange that the repo is duplicated now

@kingel
Copy link
Member

kingel commented Apr 5, 2019

yes i transfered it but as you say things are weird.. i dont have time to look into that. I will archive this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants