-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid useless reload of the page #21
base: master
Are you sure you want to change the base?
Conversation
Cookies are working without it
@kingel @ralphjacobs could you please take a look at this PR ? |
@laulaz We don't do a lot of active plone development anymore, if you want I could give you access to the repo and to pypi |
@kingel Thank you for your quick answer ! Thanks a lot ! |
@laulaz github promised to take the pr's and issues as well but no go.. I moved it to https://github.com/collective/collective.cookiecuttr so maybe you can redo your pr I added you on pypi |
Thanks !
Did you Transfer it ? it's strange that the repo is duplicated now |
yes i transfered it but as you say things are weird.. i dont have time to look into that. I will archive this repo |
We had a UX issue with page reloading after cookie acceptation.
After reading the code, we don't understand why the page had to be reloaded to activate cookies.
It's working fine without that reload.
Can you please merge this PR or explain the edge case you were wanting to handle with that reload ?