From 76e5427efa83a128d6160f287f721953127d1796 Mon Sep 17 00:00:00 2001 From: Theroxenes Date: Thu, 13 Nov 2025 19:23:24 -0500 Subject: [PATCH 1/2] Automates physical resistance for Inspire Heroics (Defense) effects Adds resistance rules elements to Inspire Heroics (Defense) spell effects. Also renames them to match remastered Rallying Anthem, and updated description to reflect added rules element. --- .../spell-effect-inspire-heroics-defense-2.json | 11 ++++++++--- .../spell-effect-inspire-heroics-defense-3.json | 11 ++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json b/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json index e553bb779ed..3905d854450 100644 --- a/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json +++ b/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json @@ -1,10 +1,10 @@ { "_id": "Chol7ExtoN2T36mP", "img": "systems/pf2e/icons/spells/inspire-heroics.webp", - "name": "Spell Effect: Inspire Heroics (Defense, +2)", + "name": "Spell Effect: Inspire Heroics (Rallying, +2)", "system": { "description": { - "value": "

Granted by succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +2 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

\n

Note: resistance is not automatically added.

" + "value": "

Granted by succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +2 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

" }, "duration": { "expiry": "turn-start", @@ -23,13 +23,18 @@ "rules": [ { "key": "FlatModifier", - "label": "Inspire Defense", + "label": "Rallying Anthem", "selector": [ "ac", "saving-throw" ], "type": "status", "value": 2 + }, + { + "key": "Resistance", + "type": "physical", + "value": "floor(( @item.level ) / 2 )" } ], "start": { diff --git a/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json b/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json index 05c3e5ea122..23e60e0422c 100644 --- a/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json +++ b/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json @@ -1,10 +1,10 @@ { "_id": "BKam63zT98iWMJH7", "img": "systems/pf2e/icons/spells/inspire-heroics.webp", - "name": "Spell Effect: Inspire Heroics (Defense, +3)", + "name": "Spell Effect: Inspire Heroics (Rallying, +3)", "system": { "description": { - "value": "

Granted by critically succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +3 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

\n

Note: resistance is not automatically added.

" + "value": "

Granted by critically succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +3 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

" }, "duration": { "expiry": "turn-start", @@ -23,13 +23,18 @@ "rules": [ { "key": "FlatModifier", - "label": "Inspire Defense", + "label": "Rallying Anthem", "selector": [ "ac", "saving-throw" ], "type": "status", "value": 3 + }, + { + "key": "Resistance", + "type": "physical", + "value": "floor(( @item.level ) / 2 )" } ], "start": { From 77b16789c57644c19696b978e212a0a0e1a017ad Mon Sep 17 00:00:00 2001 From: Theroxenes Date: Wed, 3 Dec 2025 09:24:19 -0500 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Ambrose <45524683+ammalagonc@users.noreply.github.com> --- .../spell-effects/spell-effect-inspire-heroics-defense-2.json | 3 +-- .../spell-effects/spell-effect-inspire-heroics-defense-3.json | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json b/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json index 3905d854450..ac4af0f6c40 100644 --- a/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json +++ b/packs/spell-effects/spell-effect-inspire-heroics-defense-2.json @@ -1,7 +1,7 @@ { "_id": "Chol7ExtoN2T36mP", "img": "systems/pf2e/icons/spells/inspire-heroics.webp", - "name": "Spell Effect: Inspire Heroics (Rallying, +2)", + "name": "Spell Effect: Inspire Heroics (Defense, +2)", "system": { "description": { "value": "

Granted by succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +2 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

" @@ -23,7 +23,6 @@ "rules": [ { "key": "FlatModifier", - "label": "Rallying Anthem", "selector": [ "ac", "saving-throw" diff --git a/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json b/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json index 23e60e0422c..7d93ac36b21 100644 --- a/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json +++ b/packs/spell-effects/spell-effect-inspire-heroics-defense-3.json @@ -1,7 +1,7 @@ { "_id": "BKam63zT98iWMJH7", "img": "systems/pf2e/icons/spells/inspire-heroics.webp", - "name": "Spell Effect: Inspire Heroics (Rallying, +3)", + "name": "Spell Effect: Inspire Heroics (Defense, +3)", "system": { "description": { "value": "

Granted by critically succeeding on @UUID[Compendium.pf2e.spells-srd.Item.Fortissimo Composition] to enhance @UUID[Compendium.pf2e.spells-srd.Item.Rallying Anthem].

\n

You inspire your allies to protect themselves more effectively. You and all allies in the area gain a +3 status bonus to AC and saving throws, as well as resistance equal to half the spell's rank to physical damage.

" @@ -23,7 +23,6 @@ "rules": [ { "key": "FlatModifier", - "label": "Rallying Anthem", "selector": [ "ac", "saving-throw"