Fix invalid item Documents preventing all physical item updates

Author: In3luki

src/module/item/physical/helpers.ts

@@ -264,28 +264,31 @@ function handleHPChange(item: PhysicalItemPF2e, changed: DeepPartial<PhysicalIte
         }
     }
 
-    // Get a clone of the item, through an actor clone if owned
-    const actorSource = item.actor?.toObject();
-    const changedSource = item.clone(fu.deepClone(changed), { keepId: true }).toObject();
-    const itemIndex = actorSource?.items.findIndex((i) => i._id === item._id);
-    if (itemIndex === -1) return;
-    actorSource?.items.splice(itemIndex ?? 0, 1, changedSource);
-    const actorClone = actorSource ? new ActorProxyPF2e(actorSource) : null;
-    const itemClone = actorClone?.inventory.get(item.id, { strict: true }) ?? item.clone(changed, { keepId: true });
-
-    // Adjust current HP proportionally if max HP changed
-    const maxHPDifference = itemClone.system.hp.max - item.system.hp.max;
-    if (maxHPDifference !== 0) {
-        changed.system = fu.mergeObject(changed.system ?? {}, {
-            hp: { value: Math.max(item.system.hp.value + maxHPDifference, 0) },
-        });
-    }
+    // Catch invalid items in the actor clone preventing other items from updating
+    try {
+        // Get a clone of the item, through an actor clone if owned
+        const actorSource = item.actor?.toObject();
+        const changedSource = item.clone(fu.deepClone(changed), { keepId: true }).toObject();
+        const itemIndex = actorSource?.items.findIndex((i) => i._id === item._id);
+        if (itemIndex === -1) return;
+        actorSource?.items.splice(itemIndex ?? 0, 1, changedSource);
+        const actorClone = actorSource ? new ActorProxyPF2e(actorSource) : null;
+        const itemClone = actorClone?.inventory.get(item.id, { strict: true }) ?? item.clone(changed, { keepId: true });
+
+        // Adjust current HP proportionally if max HP changed
+        const maxHPDifference = itemClone.system.hp.max - item.system.hp.max;
+        if (maxHPDifference !== 0) {
+            changed.system = fu.mergeObject(changed.system ?? {}, {
+                hp: { value: Math.max(item.system.hp.value + maxHPDifference, 0) },
+            });
+        }
 
-    // Final overage check
-    const newValue = changed.system?.hp?.value ?? itemClone.system.hp.value;
-    if (newValue > itemClone.system.hp.max) {
-        changed.system = fu.mergeObject(changed.system ?? {}, { hp: { value: itemClone.system.hp.max } });
-    }
+        // Final overage check
+        const newValue = changed.system?.hp?.value ?? itemClone.system.hp.value;
+        if (newValue > itemClone.system.hp.max) {
+            changed.system = fu.mergeObject(changed.system ?? {}, { hp: { value: itemClone.system.hp.max } });
+        }
+    } catch {}
 }
 
 /** Add and adjust properties on an item's bulk data object */