Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use data transformer unless --calldata is passed #2760

Open
cptartur opened this issue Dec 6, 2024 · 0 comments
Open

Always use data transformer unless --calldata is passed #2760

cptartur opened this issue Dec 6, 2024 · 0 comments
Labels
feature New feature request/description new sncast

Comments

@cptartur
Copy link
Member

cptartur commented Dec 6, 2024

Currently, in the calldata serialization logic in sncast we only try to use data transformer if --arguments flag is prezent. If not, and no --calldata was provided, an empty vec is used as calldata and the transaction fails after execution attempt.

The logic should be changed, so if no --arguments flag is provided, data transformer is called but with an empty vec. This way instead of provider (starknet) error, the user will be shown a nice, data transformer error.

@cptartur cptartur added feature New feature request/description sncast labels Dec 6, 2024
@cptartur cptartur moved this to New in Starknet foundry Dec 6, 2024
@github-actions github-actions bot added the new label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description new sncast
Projects
Status: New
Development

No branches or pull requests

1 participant