Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling incorrect arguments in test attributes #2484

Open
kkawula opened this issue Sep 18, 2024 · 0 comments · May be fixed by #2493
Open

Fix handling incorrect arguments in test attributes #2484

kkawula opened this issue Sep 18, 2024 · 0 comments · May be fixed by #2493
Assignees
@cptartur
Labels
bug Something isn't working snforge

Comments

@kkawula
Copy link
Collaborator

kkawula commented Sep 18, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

For example this snippet would work.

#[test]
#[fork(tomato: "red", url: "http://your.rpc.url", block_number: 123)]
fn test_using_forked_state() {
    // ...
}

But in this scenario snforge should throw an error because tomato isn't a proper argument.
@github-actions github-actions bot added the new label Sep 18, 2024
@kkawula kkawula added bug Something isn't working and removed new labels Sep 18, 2024
@cptartur cptartur moved this from New to TODO in Starknet foundry Sep 20, 2024
@cptartur cptartur self-assigned this Sep 20, 2024
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Sep 20, 2024
@cptartur cptartur linked a pull request Sep 23, 2024 that will close this issue
Draft
5 tasks
@cptartur cptartur moved this from In Progress to TODO in Starknet foundry Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
bug Something isn't working snforge
Projects
Starknet foundry
Status: TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect attributes handling foundry-rs/starknet-foundry
2 participants
@cptartur @kkawula